Re: [PATCH] tests/qtest: Add XIVE tests for the powernv10 machine

[Thomas Huth]

On 18/09/2024 19.08, Mike Kowal wrote:
> On 9/18/2024 10:05 AM, Thomas Huth wrote:
...
> > That also does not look like proper content for a header file. Please put 
> > it into a .c file instead.
>
> When these test were originally written, the authors had all of the tests 
> and their functions in one .c file.  Some thought it was too large and 
> confusing and I separated the different test functions into separate .h 
> files (and including .c files is not typically done).   I suppose I could 
> have the different functions as individual qtests, opposed  to one XIVE 
> test...   And I couldn't find an example multiple qtest .c files compiled 
> and linked together into one qtest.

There are a bunch of qtests that are linked with the object files from 
multiple .c files. Have a look at tests/qtest/meson.build, look for the 
"qtests = {" around line 320. I think you could do something similar for 
your tests here, too.

 Thomas