[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 02/67] target/ppc: Make divd[u] handler method decodetree comp
From: |
Michael Tokarev |
Subject: |
Re: [PULL 02/67] target/ppc: Make divd[u] handler method decodetree compatible |
Date: |
Tue, 5 Nov 2024 21:45:39 +0300 |
User-agent: |
Mozilla Thunderbird |
05.11.2024 21:01, Ilya Leoshkevich wrote:
On Tue, 2024-11-05 at 18:33 +0300, Michael Tokarev wrote:
04.11.2024 03:17, Nicholas Piggin wrote:
From: Ilya Leoshkevich <iii@linux.ibm.com>
This is like commit 86e6202a57b1 ("target/ppc: Make divw[u] handler
method decodetree compatible."), but for gen_op_arith_divd().
...
Come to think of it, I would recommend only the previous commit
("target/ppc: Set ctx->opcode for decode_insn32()") for stable. It
solves the whole class of potential problems like this one, and it
should apply to 7.2 as well.
Yes, "Set ctx->opcode for decode_insn32()" applies and works for all
older stable releases.
So I'm not picking up this commit ("Make divd[u] handler method decodetree
compatible") for the stable releases (not even for 9.1), and do not pick
"Make divw[u] handler" either.
The rest from this pull request which are marked for-stable, are picked
up.
The reason we also have this fix in the pull request is that long-term
the ctx->opcode field will be removed.
Thank you for the clarification!
/mjt
- [PULL 00/67] ppc-for-9.2-1 queue, Nicholas Piggin, 2024/11/03
- [PULL 03/67] ppc/pnv: Fix LPC serirq routing calculation, Nicholas Piggin, 2024/11/03
- [PULL 04/67] ppc/pnv: Fix LPC POWER8 register sanity check, Nicholas Piggin, 2024/11/03
- [PULL 05/67] target/ppc: Fix mtDPDES targeting SMT siblings, Nicholas Piggin, 2024/11/03
- [PULL 06/67] target/ppc: PMIs are level triggered, Nicholas Piggin, 2024/11/03
- [PULL 07/67] target/ppc: Fix doorbell delivery to threads in powersave, Nicholas Piggin, 2024/11/03
- [PULL 08/67] target/ppc: Fix HFSCR facility checks, Nicholas Piggin, 2024/11/03
- [PULL 09/67] target/ppc: Fix VRMA to not check virtual page class key protection, Nicholas Piggin, 2024/11/03
- [PULL 10/67] ppc/pnv: ADU fix possible buffer overrun with invalid size, Nicholas Piggin, 2024/11/03