qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 02/67] target/ppc: Make divd[u] handler method decodetree comp


From: Michael Tokarev
Subject: Re: [PULL 02/67] target/ppc: Make divd[u] handler method decodetree compatible
Date: Tue, 5 Nov 2024 21:45:39 +0300
User-agent: Mozilla Thunderbird

05.11.2024 21:01, Ilya Leoshkevich wrote:
On Tue, 2024-11-05 at 18:33 +0300, Michael Tokarev wrote:
04.11.2024 03:17, Nicholas Piggin wrote:
From: Ilya Leoshkevich <iii@linux.ibm.com>

This is like commit 86e6202a57b1 ("target/ppc: Make divw[u] handler
method decodetree compatible."), but for gen_op_arith_divd().
...
Come to think of it, I would recommend only the previous commit
("target/ppc: Set ctx->opcode for decode_insn32()") for stable. It
solves the whole class of potential problems like this one, and it
should apply to 7.2 as well.

Yes, "Set ctx->opcode for decode_insn32()" applies and works for all
older stable releases.

So I'm not picking up this commit ("Make divd[u] handler method decodetree
compatible") for the stable releases (not even for 9.1), and do not pick
"Make divw[u] handler" either.

The rest from this pull request which are marked for-stable, are picked
up.

The reason we also have this fix in the pull request is that long-term
the ctx->opcode field will be removed.

Thank you for the clarification!

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]