Re: [PATCH 14/24] exec: Declare tlb_init/destroy() in 'exec/cputlb.h'

[Philippe Mathieu-Daudé]

On 14/11/24 19:21, Richard Henderson wrote:
> On 11/13/24 17:12, Philippe Mathieu-Daudé wrote:
> > Move CPU TLB related methods to "exec/cputlb.h".
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   include/exec/cputlb.h   | 28 +++++++++++++++++++++++-----
> >   include/exec/exec-all.h | 17 -----------------
> >   accel/tcg/cpu-exec.c    |  1 +
> >   3 files changed, 24 insertions(+), 22 deletions(-)
>
> This is only within accel/tcg/.  Better to move to 
> accel/tcg/internal-common.h.

Yeah, and IIRC this is also true for some other helpers.
My thought was "better keep all the API public" but I
don't remember why I decided to go this way, since this
is of no use outside of accel/tcg/.