qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/14] pnv/xive: Fix problem with treating NVGC as a NVP


From: Nicholas Piggin
Subject: Re: [PATCH 13/14] pnv/xive: Fix problem with treating NVGC as a NVP
Date: Tue, 19 Nov 2024 15:04:19 +1000

On Wed Oct 16, 2024 at 7:13 AM AEST, Michael Kowal wrote:
> From: Glenn Miles <milesg@linux.ibm.com>
>
> When booting with PHYP, the blk/index for a NVGC was being
> mistakenly treated as the blk/index for a NVP.  Renamed
> nvp_blk/nvp_idx throughout the code to nvx_blk/nvx_idx to prevent
> confusion in the future and now we delay loading the NVP until
> the point where we know that the block and index actually point to
> a NVP.
>
> Suggested-by: Michael Kowal <kowal@us.ibm.com>
> Fixes: 6d4c4f70262 ("ppc/xive2: Support crowd-matching when looking for 
> target")

Mechanical renaming should be moved to the start of the series,
and the fix should be merged into patch 3. Commit tags should only
be used if they exist in upstream repo.

Thanks,
Nick



reply via email to

[Prev in Thread] Current Thread [Next in Thread]