Re: [PATCH 07/12] ppc/e500: Avoid abuse of container_get()

[Cédric Le Goater]

On 11/20/24 22:56, Peter Xu wrote:
> container_get() is going to become strict on not allowing to return a
> non-container.
>
> Switch the e500 user to use object_resolve_path_component() explicitly.
>
> Cc: Bharat Bhushan <r65777@freescale.com>
> Cc: qemu-ppc@nongnu.org
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>   hw/pci-host/ppce500.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c
> index b70631045a..65233b9e3f 100644
> --- a/hw/pci-host/ppce500.c
> +++ b/hw/pci-host/ppce500.c
> @@ -418,8 +418,8 @@ static const VMStateDescription vmstate_ppce500_pci = {
>   static void e500_pcihost_bridge_realize(PCIDevice *d, Error **errp)
>   {
>       PPCE500PCIBridgeState *b = PPC_E500_PCI_BRIDGE(d);
> -    PPCE500CCSRState *ccsr = CCSR(container_get(qdev_get_machine(),
> -                                  "/e500-ccsr"));
> +    PPCE500CCSRState *ccsr = CCSR(
> +        object_resolve_path_component(qdev_get_machine(), "e500-ccsr"));


why not simply use :

      CCSR(object_resolve_path("/machine/e500-ccsr", NULL));

Thanks,

C.

>   
>       memory_region_init_alias(&b->bar0, OBJECT(ccsr), "e500-pci-bar0", &ccsr->ccsr_space,
>                                0, int128_get64(ccsr->ccsr_space.size));