|
From: | Thomas Huth |
Subject: | Re: [PATCH 18/39] tests/functional: avoid accessing log_filename on earlier failures |
Date: | Fri, 22 Nov 2024 11:19:46 +0100 |
User-agent: | Mozilla Thunderbird |
On 21/11/2024 17.57, Alex Bennée wrote:
From: Daniel P. Berrangé <berrange@redhat.com> If a failure occurs early in the QemuBaseTest constructor, the 'log_filename' object atttribute may not exist yet. This happens
s/atttribute/attribute/
most notably if the QEMU_TEST_QEMU_BINARY is not set. We can't initialize 'log_filename' earlier as we use the binary to identify the architecture which is then used to build the path in which the logs are stored.
With the typo fixed: Reviewed-by: Thomas Huth <thuth@redhat.com>
[Prev in Thread] | Current Thread | [Next in Thread] |