Re: [PATCH 00/39] maintainer updates for -rc2 pre-PR

[Cédric Le Goater]

On 11/22/24 11:47, Thomas Huth wrote:
> On 21/11/2024 22.46, Cédric Le Goater wrote:
> > On 11/21/24 20:10, Thomas Huth wrote:
> > > On 21/11/2024 20.03, Cédric Le Goater wrote:
> > > > Hello Alex,
> > > >
> > > > On 11/21/24 17:57, Alex Bennée wrote:
> > > > > This is a mostly testing focused set of patches but a few bug fixes as
> > > > > well. I plan to send the PR in on Monday. I can drop any patches that
> > > > > are objected to but I think its pretty safe.
> > > > >
> > > > > Contains:
> > > > >
> > > > >    - Daniel's clean-up of functional tests
> > > > >    - Another avocado->function conversion from Thomas
> > > > >    - Update the tuxrun baseline images
> > > > >    - Minor fix to the rust pl011 device
> > > > >    - Documentation clarification on identity
> > > > >
> > > > > The following could do with some review:
> > > > >
> > > > >    tests/functional: update the x86_64 tuxrun tests
> > > > >    tests/functional: update the sparc64 tuxrun tests
> > > > >    tests/functional: update the s390x tuxrun tests
> > > > >    tests/functional: update the riscv64 tuxrun tests
> > > > >    tests/functional: update the riscv32 tuxrun tests
> > > > >    tests/functional: update the ppc64 tuxrun tests
> > > > >    tests/functional: update the ppc32 tuxrun tests
> > > > >    tests/functional: update the mips64el tuxrun tests
> > > > >    tests/functional: update the mips64 tuxrun tests
> > > > >    tests/functional: update the mips32el tuxrun tests
> > > > >    tests/functional: update the mips32 tuxrun tests
> > > > >    tests/functional: add a m68k tuxrun tests
> > > > >    tests/functional: update the i386 tuxrun tests
> > > > >    tests/functional: update the aarch64 tuxrun tests
> > > > >    tests/functional: update the arm tuxrun tests
> > > > >    tests/functional: Convert the Avocado aarch64 tuxrun tests 
> > > >
> > > > Do you think we could include patches 2-4 from this series ?
> > > >
> > > > https://lore.kernel.org/all/20241112130246.970281-1-clg@redhat.com/
> > > >
> > > > Only patch 3 lacks a R-b.
> > >
> > > I had a question on patch 3 and a suggestion on patch 4 ... could you maybe 
> > > address them first? Thanks!
> >
> > Oh Sorry I forgot.
> >
> > I did address patch 4 in my tree ... In Patch 3, EXTRA_BOOTARGS was
> > added by Alex IIRC to work around the console issue. We ended up
> > adding the sleep call. I can resend tomorrow.
>
> IMHO v4 looks fine now ( 
> https://lore.kernel.org/qemu-devel/20241122090322.1934697-1-clg@redhat.com/ ) 
> in case you want to pick it up, Alex.
>
>   Thomas

Here is a check-functional run with this series and the v4 I sent :

  https://paste.debian.net/1336417/

This system is fast so the timeouts are more certainly tests failures :

  func-sh4-sh4_tuxrun           ?
  func-rx-rx_gdbsim             
https://gitlab.com/qemu-project/qemu/-/issues/2691

Thanks,

C.