Re: [PATCH 7/7] qemu-options: Remove mentions of legacy '-machine foo,accel=bar'

[Philippe Mathieu-Daudé]

On 3/12/24 10:54, Daniel P. Berrangé wrote:
> On Tue, Dec 03, 2024 at 10:21:53AM +0100, Philippe Mathieu-Daudé wrote:
> > Since commit 6f6e1698a68 ("vl: configure accelerators from -accel
> > options") we prefer the '-accel bar' command line option.
> >
> > The new form started to be documented in commit 8d4e9146b35 ("tcg:
> > add options for enabling MTTCG"); it is safe to remove the mentions
> > of the legacy option.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   qemu-options.hx | 9 ---------
> >   1 file changed, 9 deletions(-)


> I'm not convinced we should be removing documentation for options that
> currently exist and remain supported.
>
> The documentation should be updated to say that we prefer use of '-accel'
> instead at least.
>
> Beyond that, what is our long term intention with '-machine accel=xxx' ?
>
> Is this a case where we are happy to leave '-machine accel=' as syntax
> sugar forever ?  Or is this a case where we want to deprecate it and
> eventually remove its impl (and thus the documention here)

Right, we should deprecate and then remove.