Re: [PATCH 35/71] hw/isa: Constify all Property

[Bernhard Beschow]

Am 13. Dezember 2024 19:07:09 UTC schrieb Richard Henderson 
<richard.henderson@linaro.org>:
>Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>---
> hw/isa/lpc_ich9.c | 2 +-
> hw/isa/pc87312.c  | 2 +-
> hw/isa/piix.c     | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
>index dabd1217dd..378244aa8f 100644
>--- a/hw/isa/lpc_ich9.c
>+++ b/hw/isa/lpc_ich9.c
>@@ -826,7 +826,7 @@ static const VMStateDescription vmstate_ich9_lpc = {
>     }
> };
> 
>-static Property ich9_lpc_properties[] = {
>+static const Property ich9_lpc_properties[] = {
>     DEFINE_PROP_BOOL("noreboot", ICH9LPCState, pin_strap.spkr_hi, false),
>     DEFINE_PROP_BOOL("smm-compat", ICH9LPCState, pm.smm_compat, false),
>     DEFINE_PROP_BOOL("smm-enabled", ICH9LPCState, pm.smm_enabled, false),
>diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c
>index f67155498d..7bb2af817d 100644
>--- a/hw/isa/pc87312.c
>+++ b/hw/isa/pc87312.c
>@@ -327,7 +327,7 @@ static const VMStateDescription vmstate_pc87312 = {
>     }
> };
> 
>-static Property pc87312_properties[] = {
>+static const Property pc87312_properties[] = {
>     DEFINE_PROP_UINT16("iobase", PC87312State, iobase, 0x398),
>     DEFINE_PROP_UINT8("config", PC87312State, config, 1),
>     DEFINE_PROP_END_OF_LIST()
>diff --git a/hw/isa/piix.c b/hw/isa/piix.c
>index b4a402f61b..8ec9c63b8a 100644
>--- a/hw/isa/piix.c
>+++ b/hw/isa/piix.c
>@@ -408,7 +408,7 @@ static void pci_piix_init(Object *obj)
>     object_initialize_child(obj, "rtc", &d->rtc, TYPE_MC146818_RTC);
> }
> 
>-static Property pci_piix_props[] = {
>+static const Property pci_piix_props[] = {
>     DEFINE_PROP_UINT32("smb_io_base", PIIXState, smb_io_base, 0),
>     DEFINE_PROP_BOOL("has-acpi", PIIXState, has_acpi, true),
>     DEFINE_PROP_BOOL("has-pic", PIIXState, has_pic, true),

Reviewed-by: Bernhard Beschow <shentey@gmail.com>