Re: [PATCH v2 08/15] target/ppc: Remove raise_exception_ra()

[Philippe Mathieu-Daudé]

On 28/1/25 10:46, Harsh Prateek Bora wrote:
> On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
> > Introduced in commit db789c6cd33 ("ppc: Provide basic
> > raise_exception_* functions"), raise_exception_ra() has
> > never been used. Remove as dead code.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Although there are a bunch of raise_exception_err_ra calls passing
> error_code as 0, I hope removing this is fine as still unused.

I dunno about error_code=0, where I'm suspicious is raddr=0,
I'd expect raddr=GETPC(), but I haven't bothered to check yet.

> Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
>
> > ---
> >   target/ppc/cpu.h         | 2 --
> >   target/ppc/excp_helper.c | 6 ------
> >   2 files changed, 8 deletions(-)