[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/10] accel/tcg: Add stub for probe_access()
From: |
Richard Henderson |
Subject: |
Re: [PATCH v2 04/10] accel/tcg: Add stub for probe_access() |
Date: |
Tue, 19 May 2020 14:41:37 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/15/20 10:07 AM, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé <address@hidden>
>
> The TCG helpers where added in b92e5a22ec3 in softmmu_template.h.
> probe_write() was added in there in 3b4afc9e75a to be moved out
> to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored
> as probe_access() in c25c283df0f.
> Since it is a TCG specific helper, add a stub to avoid failures
> when building without TCG, such:
>
> target/arm/helper.o: In function `probe_read':
> include/exec/exec-all.h:362: undefined reference to `probe_access'
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Cc: Richard Henderson <address@hidden>
> Cc: Emilio G. Cota <address@hidden>
> Cc: Alex Bennée <address@hidden>
> Cc: David Hildenbrand <address@hidden>
> ---
> accel/stubs/tcg-stub.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [PATCH v2 00/10] accel: Allow targets to use Kconfig, disable semihosting by default, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 01/10] MAINTAINERS: Fix KVM path expansion glob, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 02/10] MAINTAINERS: Add an 'overall' entry for accelerators, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 03/10] MAINTAINERS: Add an entry for the HAX accelerator, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 04/10] accel/tcg: Add stub for probe_access(), Philippe Mathieu-Daudé, 2020/05/15
- Re: [PATCH v2 04/10] accel/tcg: Add stub for probe_access(),
Richard Henderson <=
- [PATCH v2 05/10] Makefile: Remove dangerous EOL trailing backslash, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 06/10] Makefile: Write MINIKCONF variables as one entry per line, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 07/10] accel/Kconfig: Extract accel selectors into their own config, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 08/10] accel/Kconfig: Add the TCG selector, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 09/10] Makefile: Allow target-specific optional Kconfig, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 10/10] hw/semihosting: Make the feature depend of TCG, and allow to disable it, Philippe Mathieu-Daudé, 2020/05/15