[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 11/11] hw/semihosting: Make the feature depend of TCG, an
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it |
Date: |
Fri, 22 May 2020 17:11:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/22/20 6:26 AM, Richard Henderson wrote:
> On 5/21/20 12:59 PM, Philippe Mathieu-Daudé wrote:
>> +++ b/hw/semihosting/Kconfig
>> @@ -1,3 +1,5 @@
>>
>> +# default is 'n'
>> config SEMIHOSTING
>> - bool
>> + bool
>> + depends on TCG
>> diff --git a/target/arm/Kconfig b/target/arm/Kconfig
>> new file mode 100644
>> index 0000000000..035592dd86
>> --- /dev/null
>> +++ b/target/arm/Kconfig
>> @@ -0,0 +1,2 @@
>> +config SEMIHOSTING
>> + default y if TCG
>
> Did you answer my question about replicating the TCG test? If you did, I
> missed it...
Shortly before posting this series:
https://www.mail-archive.com/address@hidden/msg705992.html
There is indeed something wrong with this patch, but I'm not seeing it.
- semihosting only makes sense with TCG accelerator
This is the "depends on TCG"
- some targets (if built with TCG enabled) require semihosting
This would be a per-target "select SEMIHOSTING if TCG"
Another problem is some targets only require semihosting in system-mode;
and this approach select it for both system/user modes.
Paolo... help!
- [PATCH v3 05/11] Makefile: Remove dangerous EOL trailing backslash, (continued)
- [PATCH v3 05/11] Makefile: Remove dangerous EOL trailing backslash, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 06/11] Makefile: Write MINIKCONF variables as one entry per line, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 07/11] accel/Kconfig: Extract accel selectors into their own config, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 08/11] accel/Kconfig: Add the TCG selector, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 09/11] rules.mak: Add base-arch() rule, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 10/11] Makefile: Allow target-specific optional Kconfig, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it, Philippe Mathieu-Daudé, 2020/05/21
- Re: [PATCH v3 00/11] accel: Allow targets to use Kconfig, disable semihosting by default, no-reply, 2020/05/21