[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] target/riscv: Drop support for ISA spec version 1.09.
From: |
Alistair Francis |
Subject: |
Re: [PATCH v3 3/3] target/riscv: Drop support for ISA spec version 1.09.1 |
Date: |
Wed, 27 May 2020 12:58:16 -0700 |
On Wed, May 27, 2020 at 2:41 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Wed, May 27, 2020 at 6:55 AM Alistair Francis
> <alistair.francis@wdc.com> wrote:
> >
> > The RISC-V ISA spec version 1.09.1 has been deprecated in QEMU since
> > 4.1. It's not commonly used so let's remove support for it.
> >
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> > target/riscv/cpu.h | 1 -
> > target/riscv/cpu.c | 2 -
> > target/riscv/cpu_helper.c | 82 +++++-------
> > target/riscv/csr.c | 118 +++---------------
> > .../riscv/insn_trans/trans_privileged.inc.c | 18 +--
> > target/riscv/monitor.c | 5 -
> > target/riscv/op_helper.c | 17 +--
> > 7 files changed, 56 insertions(+), 187 deletions(-)
> >
>
> There are 3 more places in csr.c that need to be removed
>
> ./target/riscv/csr.c:651: if (env->priv_ver < PRIV_VERSION_1_10_0) {
> ./target/riscv/csr.c:660: if (env->priv_ver < PRIV_VERSION_1_10_0) {
> ./target/riscv/csr.c:741: } else if (env->priv_ver >= PRIV_VERSION_1_10_0)
> {
Thanks, fixed.
Alistair
>
> Regards,
> Bin