[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 20/35] hw/intc/i8259: Emit warning when old code is used
From: |
Paolo Bonzini |
Subject: |
Re: [RFC PATCH 20/35] hw/intc/i8259: Emit warning when old code is used |
Date: |
Tue, 9 Jun 2020 13:10:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote:
> This code hasn't been QOM'ified yet. Warn the user.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/intc/i8259.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
> index 51b27f6a34..9d9609cdab 100644
> --- a/hw/intc/i8259.c
> +++ b/hw/intc/i8259.c
> @@ -30,6 +30,7 @@
> #include "qemu/log.h"
> #include "hw/isa/i8259_internal.h"
> #include "trace.h"
> +#include "hw/qdev-deprecated.h"
>
> /* debug PIC */
> //#define DEBUG_PIC
> @@ -414,6 +415,8 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq)
> ISADevice *isadev;
> int i;
>
> + qdev_warn_deprecated_function_used();
> +
> irq_set = g_new0(qemu_irq, ISA_NUM_IRQS);
>
> isadev = i8259_init_chip(TYPE_I8259, bus, true);
>
This one is okay too.
Paolo
- [RFC PATCH 13/35] hw/dma/soc_dma: Emit warning when old code is used, (continued)
- [RFC PATCH 13/35] hw/dma/soc_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 14/35] hw/i386/pc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 16/35] hw/input/lasips2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 17/35] hw/input/pckbd: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 18/35] hw/input/ps2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 19/35] hw/input/tsc2005: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 20/35] hw/intc/i8259: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- Re: [RFC PATCH 20/35] hw/intc/i8259: Emit warning when old code is used,
Paolo Bonzini <=
- [RFC PATCH 21/35] hw/lm32/lm32_hwsetup: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 22/35] hw/m68k/mcf520x: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 25/35] hw/nvram/eeprom93xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 27/35] hw/ppc/ppc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 24/35] hw/misc/cbus: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 28/35] hw/ppc/ppc4xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 29/35] hw/ppc/ppc_booke: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08