[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 08/18] cpu/{avr, lm32, moxie}: Set DeviceClass vmsd field
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v6 08/18] cpu/{avr, lm32, moxie}: Set DeviceClass vmsd field (not CPUClass one) |
Date: |
Mon, 17 May 2021 07:27:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/23/21 3:16 AM, Richard Henderson wrote:
> On 4/22/21 12:38 PM, Philippe Mathieu-Daudé wrote:
>> See rationale in previous commit. Targets should use the vmsd field
>> of DeviceClass, not CPUClass. As migration is not important on the
>> avr/lm32/moxie targets, break the migration compatibility and set
>> the DeviceClass vmsd field.
>>
>> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
>> ---
>> target/avr/cpu.c | 2 +-
>> target/lm32/cpu.c | 2 +-
>> target/moxie/cpu.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> Do you not have to increment the vmstate versions?
>
> Though I can't see how the version numbers would even get compared,
> since we're looking for them in different locations?
Yes, I am not sure how that will work. Anyway, better safe than sorry!
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v6 08/18] cpu/{avr, lm32, moxie}: Set DeviceClass vmsd field (not CPUClass one),
Philippe Mathieu-Daudé <=