[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/53] docs/devel: tweak headings in monitor command docs
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 02/53] docs/devel: tweak headings in monitor command docs |
Date: |
Mon, 20 Sep 2021 09:42:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Daniel P. Berrangé <berrange@redhat.com> writes:
> The new headings reflect the intended structure of the document and will
> better suit additions that follow.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> docs/devel/writing-monitor-commands.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/docs/devel/writing-monitor-commands.rst
> b/docs/devel/writing-monitor-commands.rst
> index 497c9ce0d5..cddb36fb74 100644
> --- a/docs/devel/writing-monitor-commands.rst
> +++ b/docs/devel/writing-monitor-commands.rst
> @@ -85,8 +85,8 @@ any data". Now you're ready to enter the QMP example
> commands as explained in
> the following sections.
>
>
> -Writing a command that doesn't return data
> -------------------------------------------
> +Writing a simple command: hello-world
> +-------------------------------------
>
> That's the most simple QMP command that can be written. Usually, this kind of
> command carries some meaningful action in QEMU but here it will just print
> @@ -340,8 +340,8 @@ Please, check the "-monitor" command-line option to know
> how to open a user
> monitor.
>
>
> -Writing a command that returns data
> ------------------------------------
> +Writing more complex commands
> +-----------------------------
>
> A QMP command is capable of returning any data the QAPI supports like
> integers,
> strings, booleans, enumerations and user defined types.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- [PATCH v2 00/53] monitor: explicitly permit QMP commands to be added for all use cases, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 01/53] docs/devel: rename file for writing monitor commands, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 02/53] docs/devel: tweak headings in monitor command docs, Daniel P . Berrangé, 2021/09/14
- Re: [PATCH v2 02/53] docs/devel: tweak headings in monitor command docs,
Markus Armbruster <=
- [PATCH v2 03/53] docs/devel: document expectations for QAPI data modelling for QMP, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 04/53] docs/devel: add example of command returning unstructured text, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 05/53] docs/devel: document expectations for HMP commands in the future, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 06/53] hw/core: introduce 'format_state' callback to replace 'dump_state', Daniel P . Berrangé, 2021/09/14