[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 03/19] scripts/clean-includes: Skip symbolic links
From: |
Eric Blake |
Subject: |
Re: [PATCH v4 03/19] scripts/clean-includes: Skip symbolic links |
Date: |
Fri, 27 Jan 2023 16:47:46 -0600 |
User-agent: |
NeoMutt/20220429 |
On Thu, Jan 19, 2023 at 07:59:43AM +0100, Markus Armbruster wrote:
> When a symbolic link points to a file that needs cleaning, the script
> replaces the link with a cleaned regular file. Not wanted; skip them.
>
> We have a few symbolic links under subprojects/libvduse/ and
> subprojects/libvhost-user/.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/clean-includes | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/clean-includes b/scripts/clean-includes
> index 8e8420d785..f0466a6262 100755
> --- a/scripts/clean-includes
> +++ b/scripts/clean-includes
> @@ -113,6 +113,10 @@ EOT
>
> files=
> for f in "$@"; do
> + if [ -L "$f" ]; then
I don't see -L used with test very often, but POSIX requires it, so it
is safe for our choice of /bin/sh.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH v4 01/19] scripts/clean-includes: Fully skip / ignore files, (continued)
[PATCH v4 14/19] block: Clean up includes, Markus Armbruster, 2023/01/19
[PATCH v4 03/19] scripts/clean-includes: Skip symbolic links, Markus Armbruster, 2023/01/19
- Re: [PATCH v4 03/19] scripts/clean-includes: Skip symbolic links,
Eric Blake <=
[PATCH v4 02/19] scripts/clean-includes: Don't claim duplicate headers found when not, Markus Armbruster, 2023/01/19
[PATCH v4 04/19] bsd-user: Clean up includes, Markus Armbruster, 2023/01/19
Re: [PATCH v4 04/19] bsd-user: Clean up includes, Peter Maydell, 2023/01/27
Re: [PATCH v4 04/19] bsd-user: Clean up includes, Michael S. Tsirkin, 2023/01/27