|
From: | Michael Tokarev |
Subject: | Re: [PATCH v6 02/20] hw/riscv/virt.c: skip 'mmu-type' FDT if satp mode not set |
Date: | Fri, 30 Jun 2023 10:36:04 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 |
29.06.2023 00:30, Daniel Henrique Barboza wrote:
The absence of a satp mode in riscv_host_cpu_init() is causing the following error: $ sudo ./qemu/build/qemu-system-riscv64 -machine virt,accel=kvm \ -m 2G -smp 1 -nographic -snapshot \ -kernel ./guest_imgs/Image \ -initrd ./guest_imgs/rootfs_kvm_riscv64.img \ -append "earlycon=sbi root=/dev/ram rw" \ -cpu host ** ERROR:../target/riscv/cpu.c:320:satp_mode_str: code should not be reached Bail out! ERROR:../target/riscv/cpu.c:320:satp_mode_str: code should not be reached Aborted
Hi! Not a review/comment for the change itself, but a question about your work environment. Why do you run qemu with sudo? Is it just because your user lacks access to /dev/kvm device node (which is fixed by adding it to kvm group) ? I find it a bit worrying to see people run development as root and the recipes to run it as root ens up in even in commit messages. I think it's not good practice to do it like this, but more important is to teach users to do it this way. And this is more serious than one might think. Thanks, /mjt
[Prev in Thread] | Current Thread | [Next in Thread] |