[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 4/5] hw/char: riscv_htif: replace exit calls with proper shutd
From: |
Clément Chigot |
Subject: |
[PATCH v4 4/5] hw/char: riscv_htif: replace exit calls with proper shutdown |
Date: |
Tue, 3 Oct 2023 09:14:26 +0200 |
This replaces the exit calls by shutdown requests, ensuring a proper
cleanup of Qemu. Otherwise, some connections like gdb could be broken
before its final packet ("Wxx") is being sent. This part, being done
inside qemu_cleanup function, can be reached only when the main loop
exits after a shutdown request.
Signed-off-by: Clément Chigot <chigot@adacore.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
---
hw/char/riscv_htif.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/char/riscv_htif.c b/hw/char/riscv_htif.c
index 40de6b8b77..9bef60def1 100644
--- a/hw/char/riscv_htif.c
+++ b/hw/char/riscv_htif.c
@@ -32,6 +32,7 @@
#include "exec/address-spaces.h"
#include "exec/tswap.h"
#include "sysemu/dma.h"
+#include "sysemu/runstate.h"
#define RISCV_DEBUG_HTIF 0
#define HTIF_DEBUG(fmt, ...)
\
@@ -206,7 +207,9 @@ static void htif_handle_tohost_write(HTIFState *s, uint64_t
val_written)
g_free(sig_data);
}
- exit(exit_code);
+ qemu_system_shutdown_request_with_code(
+ SHUTDOWN_CAUSE_GUEST_SHUTDOWN, exit_code);
+ return;
} else {
uint64_t syscall[8];
cpu_physical_memory_read(payload, syscall, sizeof(syscall));
--
2.25.1
- [PATCH v4 0/5] Risc-V/gdb: replace exit calls with proper shutdown, Clément Chigot, 2023/10/03
- [PATCH v4 1/5] softmmu: add means to pass an exit code when requesting a shutdown, Clément Chigot, 2023/10/03
- [PATCH v4 3/5] hw/misc/sifive_test.c: replace exit calls with proper shutdown, Clément Chigot, 2023/10/03
- [PATCH v4 2/5] softmmu: pass the main loop status to gdb "Wxx" packet, Clément Chigot, 2023/10/03
- [PATCH v4 4/5] hw/char: riscv_htif: replace exit calls with proper shutdown,
Clément Chigot <=
- [PATCH v4 5/5] gdbstub: replace exit calls with proper shutdown for softmmu, Clément Chigot, 2023/10/03
- Re: [PATCH v4 0/5] Risc-V/gdb: replace exit calls with proper shutdown, Alistair Francis, 2023/10/04