[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 1/6] target/riscv: Remove obsolete pointer masking ext
|
From: |
Alistair Francis |
|
Subject: |
Re: [RFC PATCH v2 1/6] target/riscv: Remove obsolete pointer masking extension code. |
|
Date: |
Thu, 4 Jan 2024 16:21:39 +1000 |
On Tue, Dec 19, 2023 at 2:54 AM Alexey Baturo <baturo.alexey@gmail.com> wrote:
>
> Hi Alistair,
>
> Thanks for the lightning fast reply!
> Could you please tell who should bump those numbers and to what values?
Just increment them by 1
> Do you think I could submit this patch series for the review?
Yes, I think so
Alistair
>
> Thanks
>
> пн, 18 дек. 2023 г. в 06:11, Alistair Francis <alistair23@gmail.com>:
>>
>> On Sat, Dec 16, 2023 at 11:52 PM Alexey Baturo <baturo.alexey@gmail.com>
>> wrote:
>> >
>> > From: Alexey Baturo <baturo.alexey@gmail.com>
>> >
>> > Zjpm v0.8 is almost frozen and it's much simplier compared to the existing
>> > one:
>> > The newer version doesn't allow to specify custom mask or base for masking.
>> > Instead it allows only certain options for masking top bits.
>> >
>> > Signed-off-by: Alexey Baturo <baturo.alexey@gmail.com>
>> > ---
>> > target/riscv/cpu.c | 10 --
>> > target/riscv/cpu.h | 32 +---
>> > target/riscv/cpu_bits.h | 82 ---------
>> > target/riscv/cpu_helper.c | 52 ------
>> > target/riscv/csr.c | 326 -----------------------------------
>> > target/riscv/machine.c | 9 -
>> > target/riscv/translate.c | 27 +--
>> > target/riscv/vector_helper.c | 2 +-
>> > 8 files changed, 10 insertions(+), 530 deletions(-)
>> >
>> > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
>> > index 83c7c0cf07..1e6571ce99 100644
>> > --- a/target/riscv/cpu.c
>> > +++ b/target/riscv/cpu.c
>> > @@ -710,13 +710,6 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE
>> > *f, int flags)
>> > CSR_MSCRATCH,
>> > CSR_SSCRATCH,
>> > CSR_SATP,
>> > - CSR_MMTE,
>> > - CSR_UPMBASE,
>> > - CSR_UPMMASK,
>> > - CSR_SPMBASE,
>> > - CSR_SPMMASK,
>> > - CSR_MPMBASE,
>> > - CSR_MPMMASK,
>> > };
>> >
>> > for (i = 0; i < ARRAY_SIZE(dump_csrs); ++i) {
>> > @@ -891,8 +884,6 @@ static void riscv_cpu_reset_hold(Object *obj)
>> > }
>> > i++;
>> > }
>> > - /* mmte is supposed to have pm.current hardwired to 1 */
>> > - env->mmte |= (EXT_STATUS_INITIAL | MMTE_M_PM_CURRENT);
>> >
>> > /*
>> > * Clear mseccfg and unlock all the PMP entries upon reset.
>> > @@ -906,7 +897,6 @@ static void riscv_cpu_reset_hold(Object *obj)
>> > pmp_unlock_entries(env);
>> > #endif
>> > env->xl = riscv_cpu_mxl(env);
>> > - riscv_cpu_update_mask(env);
>> > cs->exception_index = RISCV_EXCP_NONE;
>> > env->load_res = -1;
>> > set_default_nan_mode(1, &env->fp_status);
>> > diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
>> > index d74b361be6..73f7004936 100644
>> > --- a/target/riscv/cpu.h
>> > +++ b/target/riscv/cpu.h
>> > @@ -374,18 +374,7 @@ struct CPUArchState {
>> > /* True if in debugger mode. */
>> > bool debugger;
>> >
>> > - /*
>> > - * CSRs for PointerMasking extension
>> > - */
>> > - target_ulong mmte;
>> > - target_ulong mpmmask;
>> > - target_ulong mpmbase;
>> > - target_ulong spmmask;
>> > - target_ulong spmbase;
>> > - target_ulong upmmask;
>> > - target_ulong upmbase;
>> > -
>> > - /* CSRs for execution environment configuration */
>> > + /* CSRs for execution enviornment configuration */
>> > uint64_t menvcfg;
>> > uint64_t mstateen[SMSTATEEN_MAX_COUNT];
>> > uint64_t hstateen[SMSTATEEN_MAX_COUNT];
>> > @@ -393,8 +382,6 @@ struct CPUArchState {
>> > target_ulong senvcfg;
>> > uint64_t henvcfg;
>> > #endif
>> > - target_ulong cur_pmmask;
>> > - target_ulong cur_pmbase;
>> >
>> > /* Fields from here on are preserved across CPU reset. */
>> > QEMUTimer *stimer; /* Internal timer for S-mode interrupt */
>> > @@ -543,17 +530,14 @@ FIELD(TB_FLAGS, VILL, 14, 1)
>> > FIELD(TB_FLAGS, VSTART_EQ_ZERO, 15, 1)
>> > /* The combination of MXL/SXL/UXL that applies to the current cpu mode. */
>> > FIELD(TB_FLAGS, XL, 16, 2)
>> > -/* If PointerMasking should be applied */
>> > -FIELD(TB_FLAGS, PM_MASK_ENABLED, 18, 1)
>> > -FIELD(TB_FLAGS, PM_BASE_ENABLED, 19, 1)
>> > -FIELD(TB_FLAGS, VTA, 20, 1)
>> > -FIELD(TB_FLAGS, VMA, 21, 1)
>> > +FIELD(TB_FLAGS, VTA, 18, 1)
>> > +FIELD(TB_FLAGS, VMA, 19, 1)
>> > /* Native debug itrigger */
>> > -FIELD(TB_FLAGS, ITRIGGER, 22, 1)
>> > +FIELD(TB_FLAGS, ITRIGGER, 20, 1)
>> > /* Virtual mode enabled */
>> > -FIELD(TB_FLAGS, VIRT_ENABLED, 23, 1)
>> > -FIELD(TB_FLAGS, PRIV, 24, 2)
>> > -FIELD(TB_FLAGS, AXL, 26, 2)
>> > +FIELD(TB_FLAGS, VIRT_ENABLED, 21, 1)
>> > +FIELD(TB_FLAGS, PRIV, 22, 2)
>> > +FIELD(TB_FLAGS, AXL, 24, 2)
>> >
>> > #ifdef TARGET_RISCV32
>> > #define riscv_cpu_mxl(env) ((void)(env), MXL_RV32)
>> > @@ -680,8 +664,6 @@ static inline uint32_t vext_get_vlmax(RISCVCPU *cpu,
>> > target_ulong vtype)
>> > void cpu_get_tb_cpu_state(CPURISCVState *env, vaddr *pc,
>> > uint64_t *cs_base, uint32_t *pflags);
>> >
>> > -void riscv_cpu_update_mask(CPURISCVState *env);
>> > -
>> > RISCVException riscv_csrrw(CPURISCVState *env, int csrno,
>> > target_ulong *ret_value,
>> > target_ulong new_value, target_ulong
>> > write_mask);
>> > diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h
>> > index ebd7917d49..3f9415d68d 100644
>> > --- a/target/riscv/cpu_bits.h
>> > +++ b/target/riscv/cpu_bits.h
>> > @@ -491,37 +491,6 @@
>> > #define CSR_MHPMCOUNTER30H 0xb9e
>> > #define CSR_MHPMCOUNTER31H 0xb9f
>> >
>> > -/*
>> > - * User PointerMasking registers
>> > - * NB: actual CSR numbers might be changed in future
>> > - */
>> > -#define CSR_UMTE 0x4c0
>> > -#define CSR_UPMMASK 0x4c1
>> > -#define CSR_UPMBASE 0x4c2
>> > -
>> > -/*
>> > - * Machine PointerMasking registers
>> > - * NB: actual CSR numbers might be changed in future
>> > - */
>> > -#define CSR_MMTE 0x3c0
>> > -#define CSR_MPMMASK 0x3c1
>> > -#define CSR_MPMBASE 0x3c2
>> > -
>> > -/*
>> > - * Supervisor PointerMaster registers
>> > - * NB: actual CSR numbers might be changed in future
>> > - */
>> > -#define CSR_SMTE 0x1c0
>> > -#define CSR_SPMMASK 0x1c1
>> > -#define CSR_SPMBASE 0x1c2
>> > -
>> > -/*
>> > - * Hypervisor PointerMaster registers
>> > - * NB: actual CSR numbers might be changed in future
>> > - */
>> > -#define CSR_VSMTE 0x2c0
>> > -#define CSR_VSPMMASK 0x2c1
>> > -#define CSR_VSPMBASE 0x2c2
>> > #define CSR_SCOUNTOVF 0xda0
>> >
>> > /* Crypto Extension */
>> > @@ -778,57 +747,6 @@ typedef enum RISCVException {
>> > #define HENVCFGH_PBMTE MENVCFGH_PBMTE
>> > #define HENVCFGH_STCE MENVCFGH_STCE
>> >
>> > -/* Offsets for every pair of control bits per each priv level */
>> > -#define XS_OFFSET 0ULL
>> > -#define U_OFFSET 2ULL
>> > -#define S_OFFSET 5ULL
>> > -#define M_OFFSET 8ULL
>> > -
>> > -#define PM_XS_BITS (EXT_STATUS_MASK << XS_OFFSET)
>> > -#define U_PM_ENABLE (PM_ENABLE << U_OFFSET)
>> > -#define U_PM_CURRENT (PM_CURRENT << U_OFFSET)
>> > -#define U_PM_INSN (PM_INSN << U_OFFSET)
>> > -#define S_PM_ENABLE (PM_ENABLE << S_OFFSET)
>> > -#define S_PM_CURRENT (PM_CURRENT << S_OFFSET)
>> > -#define S_PM_INSN (PM_INSN << S_OFFSET)
>> > -#define M_PM_ENABLE (PM_ENABLE << M_OFFSET)
>> > -#define M_PM_CURRENT (PM_CURRENT << M_OFFSET)
>> > -#define M_PM_INSN (PM_INSN << M_OFFSET)
>> > -
>> > -/* mmte CSR bits */
>> > -#define MMTE_PM_XS_BITS PM_XS_BITS
>> > -#define MMTE_U_PM_ENABLE U_PM_ENABLE
>> > -#define MMTE_U_PM_CURRENT U_PM_CURRENT
>> > -#define MMTE_U_PM_INSN U_PM_INSN
>> > -#define MMTE_S_PM_ENABLE S_PM_ENABLE
>> > -#define MMTE_S_PM_CURRENT S_PM_CURRENT
>> > -#define MMTE_S_PM_INSN S_PM_INSN
>> > -#define MMTE_M_PM_ENABLE M_PM_ENABLE
>> > -#define MMTE_M_PM_CURRENT M_PM_CURRENT
>> > -#define MMTE_M_PM_INSN M_PM_INSN
>> > -#define MMTE_MASK (MMTE_U_PM_ENABLE | MMTE_U_PM_CURRENT |
>> > MMTE_U_PM_INSN | \
>> > - MMTE_S_PM_ENABLE | MMTE_S_PM_CURRENT |
>> > MMTE_S_PM_INSN | \
>> > - MMTE_M_PM_ENABLE | MMTE_M_PM_CURRENT |
>> > MMTE_M_PM_INSN | \
>> > - MMTE_PM_XS_BITS)
>> > -
>> > -/* (v)smte CSR bits */
>> > -#define SMTE_PM_XS_BITS PM_XS_BITS
>> > -#define SMTE_U_PM_ENABLE U_PM_ENABLE
>> > -#define SMTE_U_PM_CURRENT U_PM_CURRENT
>> > -#define SMTE_U_PM_INSN U_PM_INSN
>> > -#define SMTE_S_PM_ENABLE S_PM_ENABLE
>> > -#define SMTE_S_PM_CURRENT S_PM_CURRENT
>> > -#define SMTE_S_PM_INSN S_PM_INSN
>> > -#define SMTE_MASK (SMTE_U_PM_ENABLE | SMTE_U_PM_CURRENT |
>> > SMTE_U_PM_INSN | \
>> > - SMTE_S_PM_ENABLE | SMTE_S_PM_CURRENT |
>> > SMTE_S_PM_INSN | \
>> > - SMTE_PM_XS_BITS)
>> > -
>> > -/* umte CSR bits */
>> > -#define UMTE_U_PM_ENABLE U_PM_ENABLE
>> > -#define UMTE_U_PM_CURRENT U_PM_CURRENT
>> > -#define UMTE_U_PM_INSN U_PM_INSN
>> > -#define UMTE_MASK (UMTE_U_PM_ENABLE | MMTE_U_PM_CURRENT |
>> > UMTE_U_PM_INSN)
>> > -
>> > /* MISELECT, SISELECT, and VSISELECT bits (AIA) */
>> > #define ISELECT_IPRIO0 0x30
>> > #define ISELECT_IPRIO15 0x3f
>> > diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
>> > index e7e23b34f4..a3d477d226 100644
>> > --- a/target/riscv/cpu_helper.c
>> > +++ b/target/riscv/cpu_helper.c
>> > @@ -135,61 +135,10 @@ void cpu_get_tb_cpu_state(CPURISCVState *env, vaddr
>> > *pc,
>> > flags = FIELD_DP32(flags, TB_FLAGS, VS, vs);
>> > flags = FIELD_DP32(flags, TB_FLAGS, XL, env->xl);
>> > flags = FIELD_DP32(flags, TB_FLAGS, AXL, cpu_address_xl(env));
>> > - if (env->cur_pmmask != 0) {
>> > - flags = FIELD_DP32(flags, TB_FLAGS, PM_MASK_ENABLED, 1);
>> > - }
>> > - if (env->cur_pmbase != 0) {
>> > - flags = FIELD_DP32(flags, TB_FLAGS, PM_BASE_ENABLED, 1);
>> > - }
>> >
>> > *pflags = flags;
>> > }
>> >
>> > -void riscv_cpu_update_mask(CPURISCVState *env)
>> > -{
>> > - target_ulong mask = 0, base = 0;
>> > - RISCVMXL xl = env->xl;
>> > - /*
>> > - * TODO: Current RVJ spec does not specify
>> > - * how the extension interacts with XLEN.
>> > - */
>> > -#ifndef CONFIG_USER_ONLY
>> > - int mode = cpu_address_mode(env);
>> > - xl = cpu_get_xl(env, mode);
>> > - if (riscv_has_ext(env, RVJ)) {
>> > - switch (mode) {
>> > - case PRV_M:
>> > - if (env->mmte & M_PM_ENABLE) {
>> > - mask = env->mpmmask;
>> > - base = env->mpmbase;
>> > - }
>> > - break;
>> > - case PRV_S:
>> > - if (env->mmte & S_PM_ENABLE) {
>> > - mask = env->spmmask;
>> > - base = env->spmbase;
>> > - }
>> > - break;
>> > - case PRV_U:
>> > - if (env->mmte & U_PM_ENABLE) {
>> > - mask = env->upmmask;
>> > - base = env->upmbase;
>> > - }
>> > - break;
>> > - default:
>> > - g_assert_not_reached();
>> > - }
>> > - }
>> > -#endif
>> > - if (xl == MXL_RV32) {
>> > - env->cur_pmmask = mask & UINT32_MAX;
>> > - env->cur_pmbase = base & UINT32_MAX;
>> > - } else {
>> > - env->cur_pmmask = mask;
>> > - env->cur_pmbase = base;
>> > - }
>> > -}
>> > -
>> > #ifndef CONFIG_USER_ONLY
>> >
>> > /*
>> > @@ -721,7 +670,6 @@ void riscv_cpu_set_mode(CPURISCVState *env,
>> > target_ulong newpriv)
>> > /* tlb_flush is unnecessary as mode is contained in mmu_idx */
>> > env->priv = newpriv;
>> > env->xl = cpu_recompute_xl(env);
>> > - riscv_cpu_update_mask(env);
>> >
>> > /*
>> > * Clear the load reservation - otherwise a reservation placed in one
>> > diff --git a/target/riscv/csr.c b/target/riscv/csr.c
>> > index fde7ce1a53..ea4e1ac6ef 100644
>> > --- a/target/riscv/csr.c
>> > +++ b/target/riscv/csr.c
>> > @@ -483,16 +483,6 @@ static RISCVException hgatp(CPURISCVState *env, int
>> > csrno)
>> > return hmode(env, csrno);
>> > }
>> >
>> > -/* Checks if PointerMasking registers could be accessed */
>> > -static RISCVException pointer_masking(CPURISCVState *env, int csrno)
>> > -{
>> > - /* Check if j-ext is present */
>> > - if (riscv_has_ext(env, RVJ)) {
>> > - return RISCV_EXCP_NONE;
>> > - }
>> > - return RISCV_EXCP_ILLEGAL_INST;
>> > -}
>> > -
>> > static int aia_hmode(CPURISCVState *env, int csrno)
>> > {
>> > if (!riscv_cpu_cfg(env)->ext_ssaia) {
>> > @@ -1355,7 +1345,6 @@ static RISCVException write_mstatus(CPURISCVState
>> > *env, int csrno,
>> > env->xl = cpu_recompute_xl(env);
>> > }
>> >
>> > - riscv_cpu_update_mask(env);
>> > return RISCV_EXCP_NONE;
>> > }
>> >
>> > @@ -3900,302 +3889,6 @@ static RISCVException read_tinfo(CPURISCVState
>> > *env, int csrno,
>> > return RISCV_EXCP_NONE;
>> > }
>> >
>> > -/*
>> > - * Functions to access Pointer Masking feature registers
>> > - * We have to check if current priv lvl could modify
>> > - * csr in given mode
>> > - */
>> > -static bool check_pm_current_disabled(CPURISCVState *env, int csrno)
>> > -{
>> > - int csr_priv = get_field(csrno, 0x300);
>> > - int pm_current;
>> > -
>> > - if (env->debugger) {
>> > - return false;
>> > - }
>> > - /*
>> > - * If priv lvls differ that means we're accessing csr from higher
>> > priv lvl,
>> > - * so allow the access
>> > - */
>> > - if (env->priv != csr_priv) {
>> > - return false;
>> > - }
>> > - switch (env->priv) {
>> > - case PRV_M:
>> > - pm_current = get_field(env->mmte, M_PM_CURRENT);
>> > - break;
>> > - case PRV_S:
>> > - pm_current = get_field(env->mmte, S_PM_CURRENT);
>> > - break;
>> > - case PRV_U:
>> > - pm_current = get_field(env->mmte, U_PM_CURRENT);
>> > - break;
>> > - default:
>> > - g_assert_not_reached();
>> > - }
>> > - /* It's same priv lvl, so we allow to modify csr only if
>> > pm.current==1 */
>> > - return !pm_current;
>> > -}
>> > -
>> > -static RISCVException read_mmte(CPURISCVState *env, int csrno,
>> > - target_ulong *val)
>> > -{
>> > - *val = env->mmte & MMTE_MASK;
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException write_mmte(CPURISCVState *env, int csrno,
>> > - target_ulong val)
>> > -{
>> > - uint64_t mstatus;
>> > - target_ulong wpri_val = val & MMTE_MASK;
>> > -
>> > - if (val != wpri_val) {
>> > - qemu_log_mask(LOG_GUEST_ERROR, "%s" TARGET_FMT_lx " %s"
>> > - TARGET_FMT_lx "\n", "MMTE: WPRI violation written
>> > 0x",
>> > - val, "vs expected 0x", wpri_val);
>> > - }
>> > - /* for machine mode pm.current is hardwired to 1 */
>> > - wpri_val |= MMTE_M_PM_CURRENT;
>> > -
>> > - /* hardwiring pm.instruction bit to 0, since it's not supported yet */
>> > - wpri_val &= ~(MMTE_M_PM_INSN | MMTE_S_PM_INSN | MMTE_U_PM_INSN);
>> > - env->mmte = wpri_val | EXT_STATUS_DIRTY;
>> > - riscv_cpu_update_mask(env);
>> > -
>> > - /* Set XS and SD bits, since PM CSRs are dirty */
>> > - mstatus = env->mstatus | MSTATUS_XS;
>> > - write_mstatus(env, csrno, mstatus);
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException read_smte(CPURISCVState *env, int csrno,
>> > - target_ulong *val)
>> > -{
>> > - *val = env->mmte & SMTE_MASK;
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException write_smte(CPURISCVState *env, int csrno,
>> > - target_ulong val)
>> > -{
>> > - target_ulong wpri_val = val & SMTE_MASK;
>> > -
>> > - if (val != wpri_val) {
>> > - qemu_log_mask(LOG_GUEST_ERROR, "%s" TARGET_FMT_lx " %s"
>> > - TARGET_FMT_lx "\n", "SMTE: WPRI violation written
>> > 0x",
>> > - val, "vs expected 0x", wpri_val);
>> > - }
>> > -
>> > - /* if pm.current==0 we can't modify current PM CSRs */
>> > - if (check_pm_current_disabled(env, csrno)) {
>> > - return RISCV_EXCP_NONE;
>> > - }
>> > -
>> > - wpri_val |= (env->mmte & ~SMTE_MASK);
>> > - write_mmte(env, csrno, wpri_val);
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException read_umte(CPURISCVState *env, int csrno,
>> > - target_ulong *val)
>> > -{
>> > - *val = env->mmte & UMTE_MASK;
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException write_umte(CPURISCVState *env, int csrno,
>> > - target_ulong val)
>> > -{
>> > - target_ulong wpri_val = val & UMTE_MASK;
>> > -
>> > - if (val != wpri_val) {
>> > - qemu_log_mask(LOG_GUEST_ERROR, "%s" TARGET_FMT_lx " %s"
>> > - TARGET_FMT_lx "\n", "UMTE: WPRI violation written
>> > 0x",
>> > - val, "vs expected 0x", wpri_val);
>> > - }
>> > -
>> > - if (check_pm_current_disabled(env, csrno)) {
>> > - return RISCV_EXCP_NONE;
>> > - }
>> > -
>> > - wpri_val |= (env->mmte & ~UMTE_MASK);
>> > - write_mmte(env, csrno, wpri_val);
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException read_mpmmask(CPURISCVState *env, int csrno,
>> > - target_ulong *val)
>> > -{
>> > - *val = env->mpmmask;
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException write_mpmmask(CPURISCVState *env, int csrno,
>> > - target_ulong val)
>> > -{
>> > - uint64_t mstatus;
>> > -
>> > - env->mpmmask = val;
>> > - if ((cpu_address_mode(env) == PRV_M) && (env->mmte & M_PM_ENABLE)) {
>> > - env->cur_pmmask = val;
>> > - }
>> > - env->mmte |= EXT_STATUS_DIRTY;
>> > -
>> > - /* Set XS and SD bits, since PM CSRs are dirty */
>> > - mstatus = env->mstatus | MSTATUS_XS;
>> > - write_mstatus(env, csrno, mstatus);
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException read_spmmask(CPURISCVState *env, int csrno,
>> > - target_ulong *val)
>> > -{
>> > - *val = env->spmmask;
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException write_spmmask(CPURISCVState *env, int csrno,
>> > - target_ulong val)
>> > -{
>> > - uint64_t mstatus;
>> > -
>> > - /* if pm.current==0 we can't modify current PM CSRs */
>> > - if (check_pm_current_disabled(env, csrno)) {
>> > - return RISCV_EXCP_NONE;
>> > - }
>> > - env->spmmask = val;
>> > - if ((cpu_address_mode(env) == PRV_S) && (env->mmte & S_PM_ENABLE)) {
>> > - env->cur_pmmask = val;
>> > - if (cpu_get_xl(env, PRV_S) == MXL_RV32) {
>> > - env->cur_pmmask &= UINT32_MAX;
>> > - }
>> > - }
>> > - env->mmte |= EXT_STATUS_DIRTY;
>> > -
>> > - /* Set XS and SD bits, since PM CSRs are dirty */
>> > - mstatus = env->mstatus | MSTATUS_XS;
>> > - write_mstatus(env, csrno, mstatus);
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException read_upmmask(CPURISCVState *env, int csrno,
>> > - target_ulong *val)
>> > -{
>> > - *val = env->upmmask;
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException write_upmmask(CPURISCVState *env, int csrno,
>> > - target_ulong val)
>> > -{
>> > - uint64_t mstatus;
>> > -
>> > - /* if pm.current==0 we can't modify current PM CSRs */
>> > - if (check_pm_current_disabled(env, csrno)) {
>> > - return RISCV_EXCP_NONE;
>> > - }
>> > - env->upmmask = val;
>> > - if ((cpu_address_mode(env) == PRV_U) && (env->mmte & U_PM_ENABLE)) {
>> > - env->cur_pmmask = val;
>> > - if (cpu_get_xl(env, PRV_U) == MXL_RV32) {
>> > - env->cur_pmmask &= UINT32_MAX;
>> > - }
>> > - }
>> > - env->mmte |= EXT_STATUS_DIRTY;
>> > -
>> > - /* Set XS and SD bits, since PM CSRs are dirty */
>> > - mstatus = env->mstatus | MSTATUS_XS;
>> > - write_mstatus(env, csrno, mstatus);
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException read_mpmbase(CPURISCVState *env, int csrno,
>> > - target_ulong *val)
>> > -{
>> > - *val = env->mpmbase;
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException write_mpmbase(CPURISCVState *env, int csrno,
>> > - target_ulong val)
>> > -{
>> > - uint64_t mstatus;
>> > -
>> > - env->mpmbase = val;
>> > - if ((cpu_address_mode(env) == PRV_M) && (env->mmte & M_PM_ENABLE)) {
>> > - env->cur_pmbase = val;
>> > - }
>> > - env->mmte |= EXT_STATUS_DIRTY;
>> > -
>> > - /* Set XS and SD bits, since PM CSRs are dirty */
>> > - mstatus = env->mstatus | MSTATUS_XS;
>> > - write_mstatus(env, csrno, mstatus);
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException read_spmbase(CPURISCVState *env, int csrno,
>> > - target_ulong *val)
>> > -{
>> > - *val = env->spmbase;
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException write_spmbase(CPURISCVState *env, int csrno,
>> > - target_ulong val)
>> > -{
>> > - uint64_t mstatus;
>> > -
>> > - /* if pm.current==0 we can't modify current PM CSRs */
>> > - if (check_pm_current_disabled(env, csrno)) {
>> > - return RISCV_EXCP_NONE;
>> > - }
>> > - env->spmbase = val;
>> > - if ((cpu_address_mode(env) == PRV_S) && (env->mmte & S_PM_ENABLE)) {
>> > - env->cur_pmbase = val;
>> > - if (cpu_get_xl(env, PRV_S) == MXL_RV32) {
>> > - env->cur_pmbase &= UINT32_MAX;
>> > - }
>> > - }
>> > - env->mmte |= EXT_STATUS_DIRTY;
>> > -
>> > - /* Set XS and SD bits, since PM CSRs are dirty */
>> > - mstatus = env->mstatus | MSTATUS_XS;
>> > - write_mstatus(env, csrno, mstatus);
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException read_upmbase(CPURISCVState *env, int csrno,
>> > - target_ulong *val)
>> > -{
>> > - *val = env->upmbase;
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > -static RISCVException write_upmbase(CPURISCVState *env, int csrno,
>> > - target_ulong val)
>> > -{
>> > - uint64_t mstatus;
>> > -
>> > - /* if pm.current==0 we can't modify current PM CSRs */
>> > - if (check_pm_current_disabled(env, csrno)) {
>> > - return RISCV_EXCP_NONE;
>> > - }
>> > - env->upmbase = val;
>> > - if ((cpu_address_mode(env) == PRV_U) && (env->mmte & U_PM_ENABLE)) {
>> > - env->cur_pmbase = val;
>> > - if (cpu_get_xl(env, PRV_U) == MXL_RV32) {
>> > - env->cur_pmbase &= UINT32_MAX;
>> > - }
>> > - }
>> > - env->mmte |= EXT_STATUS_DIRTY;
>> > -
>> > - /* Set XS and SD bits, since PM CSRs are dirty */
>> > - mstatus = env->mstatus | MSTATUS_XS;
>> > - write_mstatus(env, csrno, mstatus);
>> > - return RISCV_EXCP_NONE;
>> > -}
>> > -
>> > #endif
>> >
>> > /* Crypto Extension */
>> > @@ -4800,25 +4493,6 @@ riscv_csr_operations csr_ops[CSR_TABLE_SIZE] = {
>> > [CSR_TDATA3] = { "tdata3", debug, read_tdata, write_tdata },
>> > [CSR_TINFO] = { "tinfo", debug, read_tinfo, write_ignore },
>> >
>> > - /* User Pointer Masking */
>> > - [CSR_UMTE] = { "umte", pointer_masking, read_umte,
>> > write_umte },
>> > - [CSR_UPMMASK] = { "upmmask", pointer_masking, read_upmmask,
>> > - write_upmmask
>> > },
>> > - [CSR_UPMBASE] = { "upmbase", pointer_masking, read_upmbase,
>> > - write_upmbase
>> > },
>> > - /* Machine Pointer Masking */
>> > - [CSR_MMTE] = { "mmte", pointer_masking, read_mmte,
>> > write_mmte },
>> > - [CSR_MPMMASK] = { "mpmmask", pointer_masking, read_mpmmask,
>> > - write_mpmmask
>> > },
>> > - [CSR_MPMBASE] = { "mpmbase", pointer_masking, read_mpmbase,
>> > - write_mpmbase
>> > },
>> > - /* Supervisor Pointer Masking */
>> > - [CSR_SMTE] = { "smte", pointer_masking, read_smte,
>> > write_smte },
>> > - [CSR_SPMMASK] = { "spmmask", pointer_masking, read_spmmask,
>> > - write_spmmask
>> > },
>> > - [CSR_SPMBASE] = { "spmbase", pointer_masking, read_spmbase,
>> > - write_spmbase
>> > },
>> > -
>> > /* Performance Counters */
>> > [CSR_HPMCOUNTER3] = { "hpmcounter3", ctr, read_hpmcounter },
>> > [CSR_HPMCOUNTER4] = { "hpmcounter4", ctr, read_hpmcounter },
>> > diff --git a/target/riscv/machine.c b/target/riscv/machine.c
>> > index fdde243e04..860fe56d43 100644
>> > --- a/target/riscv/machine.c
>> > +++ b/target/riscv/machine.c
>> > @@ -164,14 +164,6 @@ static const VMStateDescription
>> > vmstate_pointermasking = {
>> > .minimum_version_id = 1,
>>
>> We want to bump the version_id and minimum_version_id
>>
>> Alistair
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [RFC PATCH v2 1/6] target/riscv: Remove obsolete pointer masking extension code.,
Alistair Francis <=