Re: [PATCH v3 03/13] target/riscv/gdbstub.c: use 'vlenb' instead of shifting 'vlen'

[Alistair Francis]

On Wed, Jan 17, 2024 at 7:00 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  target/riscv/gdbstub.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/riscv/gdbstub.c b/target/riscv/gdbstub.c
> index 58b3ace0fe..5ab0abda19 100644
> --- a/target/riscv/gdbstub.c
> +++ b/target/riscv/gdbstub.c
> @@ -130,7 +130,7 @@ static int riscv_gdb_set_fpu(CPURISCVState *env, uint8_t 
> *mem_buf, int n)
>
>  static int riscv_gdb_get_vector(CPURISCVState *env, GByteArray *buf, int n)
>  {
> -    uint16_t vlenb = riscv_cpu_cfg(env)->vlen >> 3;
> +    uint16_t vlenb = riscv_cpu_cfg(env)->vlenb;
>      if (n < 32) {
>          int i;
>          int cnt = 0;
> @@ -146,7 +146,7 @@ static int riscv_gdb_get_vector(CPURISCVState *env, 
> GByteArray *buf, int n)
>
>  static int riscv_gdb_set_vector(CPURISCVState *env, uint8_t *mem_buf, int n)
>  {
> -    uint16_t vlenb = riscv_cpu_cfg(env)->vlen >> 3;
> +    uint16_t vlenb = riscv_cpu_cfg(env)->vlenb;
>      if (n < 32) {
>          int i;
>          for (i = 0; i < vlenb; i += 8) {
> @@ -266,7 +266,7 @@ static int ricsv_gen_dynamic_vector_xml(CPUState *cs, int 
> base_reg)
>      RISCVCPU *cpu = RISCV_CPU(cs);
>      GString *s = g_string_new(NULL);
>      g_autoptr(GString) ts = g_string_new("");
> -    int reg_width = cpu->cfg.vlen;
> +    int reg_width = cpu->cfg.vlenb << 3;
>      int num_regs = 0;
>      int i;
>
> --
> 2.43.0
>
>