[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] target/arm: Replace sprintf() by snprintf()
From: |
Peter Maydell |
Subject: |
Re: [PATCH 8/9] target/arm: Replace sprintf() by snprintf() |
Date: |
Thu, 11 Apr 2024 12:32:40 +0100 |
On Thu, 11 Apr 2024 at 11:44, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1,
> resulting in painful developper experience. Use snprintf() instead.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/arm/cpu64.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
> index 985b1efe16..f0f4fe6714 100644
> --- a/target/arm/cpu64.c
> +++ b/target/arm/cpu64.c
> @@ -433,7 +433,7 @@ void aarch64_add_sve_properties(Object *obj)
>
> for (vq = 1; vq <= ARM_MAX_VQ; ++vq) {
> char name[8];
> - sprintf(name, "sve%d", vq * 128);
> + snprintf(name, sizeof(name), "sve%d", vq * 128);
> object_property_add(obj, name, "bool", cpu_arm_get_vq,
> cpu_arm_set_vq, NULL, &cpu->sve_vq);
> }
> @@ -458,7 +458,7 @@ void aarch64_add_sme_properties(Object *obj)
>
> for (vq = 1; vq <= ARM_MAX_VQ; vq <<= 1) {
> char name[8];
> - sprintf(name, "sme%d", vq * 128);
> + snprintf(name, sizeof(name), "sme%d", vq * 128);
> object_property_add(obj, name, "bool", cpu_arm_get_vq,
> cpu_arm_set_vq, NULL, &cpu->sme_vq);
> }
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH 4/9] linux-user/flatload: Replace sprintf() by snprintf(), (continued)
- [PATCH 4/9] linux-user/flatload: Replace sprintf() by snprintf(), Philippe Mathieu-Daudé, 2024/04/11
- [PATCH 5/9] hw/misc/imx: Replace sprintf() by snprintf(), Philippe Mathieu-Daudé, 2024/04/11
- [PATCH 6/9] hw/net/rocker: Replace sprintf() by snprintf(), Philippe Mathieu-Daudé, 2024/04/11
- [PATCH 7/9] hw/riscv/virt: Replace sprintf() by snprintf(), Philippe Mathieu-Daudé, 2024/04/11
- [PATCH 8/9] target/arm: Replace sprintf() by snprintf(), Philippe Mathieu-Daudé, 2024/04/11
- [PATCH 9/9] target/i386: Replace sprintf() by snprintf(), Philippe Mathieu-Daudé, 2024/04/11