|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 2/2] hw: Add a Kconfig switch for the TYPE_CPU_CLUSTER device |
Date: | Sat, 13 Apr 2024 11:50:51 +0200 |
User-agent: | Mozilla Thunderbird |
On 12/4/24 11:15, Thomas Huth wrote:
On 12/04/2024 08.20, Thomas Huth wrote:The cpu-cluster device is only needed for some few arm and riscv machines. Let's avoid compiling and linking it if it is not really necessary.
I expect clustering become the new default for heterogeneous machines, but we are not there yet.
Signed-off-by: Thomas Huth <thuth@redhat.com> --- hw/arm/Kconfig | 3 +++ hw/cpu/Kconfig | 3 +++ hw/cpu/meson.build | 2 +- hw/riscv/Kconfig | 2 ++ 4 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/cpu/meson.build b/hw/cpu/meson.build index 38cdcfbe57..43a34c4c6e 100644 --- a/hw/cpu/meson.build +++ b/hw/cpu/meson.build @@ -1,4 +1,4 @@ -system_ss.add(files('core.c', 'cluster.c'))+system_ss.add(when: 'CONFIG_CPU_CLUSTER', if_true: files('core.c', 'cluster.c'))Oops, sorry, the switch should only be used for cluster.c, not for core.c. I'll change it in v2 ...
For v2: Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[Prev in Thread] | Current Thread | [Next in Thread] |