|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 17/24] exec: Include missing 'qemu/log-for-trace.h' header in 'exec/log.h' |
Date: | Mon, 22 Apr 2024 11:05:18 +0200 |
User-agent: | Mozilla Thunderbird |
On 21/4/24 18:44, Richard Henderson wrote:
On 4/18/24 12:25, Philippe Mathieu-Daudé wrote:"exec/log.h" accesses the qemu_loglevel variable, which is declared in "qemu/log-for-trace.h". Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- include/exec/log.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/exec/log.h b/include/exec/log.h index 4a7375a45f..e0ff778a10 100644 --- a/include/exec/log.h +++ b/include/exec/log.h @@ -2,6 +2,7 @@ #define QEMU_EXEC_LOG_H #include "qemu/log.h" +#include "qemu/log-for-trace.h" #include "hw/core/cpu.h" #include "disas/disas.h"I disagree: qemu/log.h is the main file; log-for-trace.h was split out for other usage. That shouldn't mean that log-for-trace.h needs to be spread around.
Good point, I haven't noticed we can just move the qemu_loglevel declaration.
[Prev in Thread] | Current Thread | [Next in Thread] |