Re: [PATCH v2 02/15] hw/riscv: add riscv-iommu-bits.h

[Daniel Henrique Barboza]

On 5/15/24 07:02, Eric Cheng wrote:
> On 3/8/2024 12:03 AM, Daniel Henrique Barboza wrote:
> > From: Tomasz Jeznach <tjeznach@rivosinc.com>
> >
> > This header will be used by the RISC-V IOMMU emulation to be added
> > in the next patch. Due to its size it's being sent in separate for
> > an easier review.
> >
> > One thing to notice is that this header can be replaced by the future
> > Linux RISC-V IOMMU driver header, which would become a linux-header we
> > would import instead of keeping our own. The Linux implementation isn't
> > upstream yet so for now we'll have to manage riscv-iommu-bits.h.
> >
> > Signed-off-by: Tomasz Jeznach <tjeznach@rivosinc.com>
> > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> > ---
> >   hw/riscv/riscv-iommu-bits.h | 335 ++++++++++++++++++++++++++++++++++++
> >   1 file changed, 335 insertions(+)
> >   create mode 100644 hw/riscv/riscv-iommu-bits.h
> >
> > diff --git a/hw/riscv/riscv-iommu-bits.h b/hw/riscv/riscv-iommu-bits.h
> > new file mode 100644
> > index 0000000000..8e80b1e52a
> > --- /dev/null
> > +++ b/hw/riscv/riscv-iommu-bits.h
> > @@ -0,0 +1,335 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Copyright © 2022-2023 Rivos Inc.
> > + * Copyright © 2023 FORTH-ICS/CARV
> > + * Copyright © 2023 RISC-V IOMMU Task Group
> > + *
> > + * RISC-V Ziommu - Register Layout and Data Structures.
>
> Is there still the term Ziommu today? cannot be googled. May be just a 
> transient term during spec development? it puzzles new comers.

Fair point. I'll remove any 'ziommu' references in all patches.


Thanks,

Daniel


> > + *
> > + * Based on the IOMMU spec version 1.0, 3/2023
> > + * https://github.com/riscv-non-isa/riscv-iommu
> > + */
> > +