[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 06/12] tests/data/acpi/virt: Move ACPI tables under aarch6
From: |
Sunil V L |
Subject: |
Re: [PATCH v2 06/12] tests/data/acpi/virt: Move ACPI tables under aarch64 |
Date: |
Mon, 27 May 2024 20:46:29 +0530 |
On Mon, May 27, 2024 at 12:12:10PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Sunil,
>
> On 24/5/24 08:14, Sunil V L wrote:
> > Since virt is a common machine name across architectures like ARM64 and
> > RISC-V, move existing ARM64 ACPI tables under aarch64 folder so that
> > RISC-V tables can be added under riscv64 folder in future.
> >
> > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> > Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> > tests/data/acpi/virt/{ => aarch64}/APIC | Bin
>
> The usual pattern is {target}/{machine}, so instead of:
>
> microvm/
> pc/
> q35/
> virt/aarch64/
> virt/riscv64/
>
> (which is odd because q35 is the x86 'virt'), I'd rather see:
>
> x86/microvm/
> x86/pc/
> x86/q35/
> aarch64/virt/
> riscv64/virt/
>
> Anyhow just my 2 cents, up to the ACPI maintainers :)
>
Hi Phil,
Your suggestion does make sense to me. Let me wait for feedback from
ARM/ACPI maintainers.
Thanks,
Sunil
- [PATCH v2 00/12] Add support for RISC-V ACPI tests, Sunil V L, 2024/05/24
- [PATCH v2 01/12] uefi-test-tools/UefiTestToolsPkg: Add RISC-V support, Sunil V L, 2024/05/24
- [PATCH v2 02/12] uefi-test-tools: Add support for python based build script, Sunil V L, 2024/05/24
- [PATCH v2 03/12] tests/data/uefi-boot-images: Add RISC-V ISO image, Sunil V L, 2024/05/24
- [PATCH v2 04/12] qtest: bios-tables-test: Rename aarch64 tests with aarch64 in them, Sunil V L, 2024/05/24
- [PATCH v2 05/12] tests/qtest/bios-tables-test.c: Add support for arch in path, Sunil V L, 2024/05/24
- [PATCH v2 06/12] tests/data/acpi/virt: Move ACPI tables under aarch64, Sunil V L, 2024/05/24
- [PATCH v2 07/12] meson.build: Add RISC-V to the edk2-target list, Sunil V L, 2024/05/24
- [PATCH v2 09/12] tests/data/acpi/rebuild-expected-aml.sh: Add RISC-V, Sunil V L, 2024/05/24
- [PATCH v2 08/12] pc-bios/meson.build: Add support for RISC-V in unpack_edk2_blobs, Sunil V L, 2024/05/24
- [PATCH v2 10/12] tests/qtest/bios-tables-test: Add empty ACPI data files for RISC-V, Sunil V L, 2024/05/24
- [PATCH v2 12/12] tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V, Sunil V L, 2024/05/24
- [PATCH v2 11/12] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V, Sunil V L, 2024/05/24