Re: [PATCH v2 1/3] hw: Remove unused inclusion of hw/char/serial.h

[Alistair Francis]

On Thu, Sep 5, 2024 at 5:40 PM Bernhard Beschow <shentey@gmail.com> wrote:
>
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>

Acked-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  hw/char/riscv_htif.c | 1 -
>  hw/ppc/prep.c        | 1 -
>  hw/riscv/sifive_e.c  | 1 -
>  hw/riscv/sifive_u.c  | 1 -
>  4 files changed, 4 deletions(-)
>
> diff --git a/hw/char/riscv_htif.c b/hw/char/riscv_htif.c
> index 9bef60def1..54fd55c3e6 100644
> --- a/hw/char/riscv_htif.c
> +++ b/hw/char/riscv_htif.c
> @@ -24,7 +24,6 @@
>  #include "qapi/error.h"
>  #include "qemu/log.h"
>  #include "hw/char/riscv_htif.h"
> -#include "hw/char/serial.h"
>  #include "chardev/char.h"
>  #include "chardev/char-fe.h"
>  #include "qemu/timer.h"
> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
> index 4eb5477069..fb58c312ac 100644
> --- a/hw/ppc/prep.c
> +++ b/hw/ppc/prep.c
> @@ -25,7 +25,6 @@
>
>  #include "qemu/osdep.h"
>  #include "hw/rtc/m48t59.h"
> -#include "hw/char/serial.h"
>  #include "hw/block/fdc.h"
>  #include "net/net.h"
>  #include "hw/isa/isa.h"
> diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c
> index 87d9602383..5a1959f2a9 100644
> --- a/hw/riscv/sifive_e.c
> +++ b/hw/riscv/sifive_e.c
> @@ -35,7 +35,6 @@
>  #include "hw/boards.h"
>  #include "hw/loader.h"
>  #include "hw/sysbus.h"
> -#include "hw/char/serial.h"
>  #include "hw/misc/unimp.h"
>  #include "target/riscv/cpu.h"
>  #include "hw/riscv/riscv_hart.h"
> diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
> index af5f923f54..efc8443c84 100644
> --- a/hw/riscv/sifive_u.c
> +++ b/hw/riscv/sifive_u.c
> @@ -43,7 +43,6 @@
>  #include "hw/irq.h"
>  #include "hw/loader.h"
>  #include "hw/sysbus.h"
> -#include "hw/char/serial.h"
>  #include "hw/cpu/cluster.h"
>  #include "hw/misc/unimp.h"
>  #include "hw/sd/sd.h"
> --
> 2.46.0
>
>