[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 4/9] rust: vmstate: implement Zeroable for VMStateField
From: |
Paolo Bonzini |
Subject: |
[RFC PATCH 4/9] rust: vmstate: implement Zeroable for VMStateField |
Date: |
Tue, 31 Dec 2024 01:23:31 +0100 |
This shortens a bit the constants. Do not bother using it
in the vmstate macros since most of them will go away soon.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
rust/qemu-api/src/vmstate.rs | 18 +++---------------
rust/qemu-api/src/zeroable.rs | 31 +++++++++++++++++++++++++++++++
2 files changed, 34 insertions(+), 15 deletions(-)
diff --git a/rust/qemu-api/src/vmstate.rs b/rust/qemu-api/src/vmstate.rs
index 079c19c687b..49d0a3c31d4 100644
--- a/rust/qemu-api/src/vmstate.rs
+++ b/rust/qemu-api/src/vmstate.rs
@@ -21,8 +21,8 @@
use core::{marker::PhantomData, mem, ptr::NonNull};
-use crate::bindings::VMStateFlags;
pub use crate::bindings::{VMStateDescription, VMStateField};
+use crate::bindings::VMStateFlags;
/// This macro is used to call a function with a generic argument bound
/// to the type of a field. The function must take a
@@ -488,20 +488,8 @@ macro_rules! vmstate_fields {
static _FIELDS: &[$crate::bindings::VMStateField] = &[
$($field),*,
$crate::bindings::VMStateField {
- name: ::core::ptr::null(),
- err_hint: ::core::ptr::null(),
- offset: 0,
- size: 0,
- start: 0,
- num: 0,
- num_offset: 0,
- size_offset: 0,
- info: ::core::ptr::null(),
- flags: VMStateFlags::VMS_END,
- vmsd: ::core::ptr::null(),
- version_id: 0,
- struct_version_id: 0,
- field_exists: None,
+ flags: $crate::bindings::VMStateFlags::VMS_END,
+ ..$crate::zeroable::Zeroable::ZERO
}
];
_FIELDS.as_ptr()
diff --git a/rust/qemu-api/src/zeroable.rs b/rust/qemu-api/src/zeroable.rs
index 6125aeed8b4..57cac96de06 100644
--- a/rust/qemu-api/src/zeroable.rs
+++ b/rust/qemu-api/src/zeroable.rs
@@ -49,6 +49,37 @@ unsafe impl Zeroable for crate::bindings::Property {
};
}
+// bindgen does not derive Default here
+#[allow(clippy::derivable_impls)]
+impl Default for crate::bindings::VMStateFlags {
+ fn default() -> Self {
+ Self(0)
+ }
+}
+
+unsafe impl Zeroable for crate::bindings::VMStateFlags {
+ const ZERO: Self = Self(0);
+}
+
+unsafe impl Zeroable for crate::bindings::VMStateField {
+ const ZERO: Self = Self {
+ name: ptr::null(),
+ err_hint: ptr::null(),
+ offset: 0,
+ size: 0,
+ start: 0,
+ num: 0,
+ num_offset: 0,
+ size_offset: 0,
+ info: ptr::null(),
+ flags: Zeroable::ZERO,
+ vmsd: ptr::null(),
+ version_id: 0,
+ struct_version_id: 0,
+ field_exists: None,
+ };
+}
+
unsafe impl Zeroable for crate::bindings::VMStateDescription {
const ZERO: Self = Self {
name: ptr::null(),
--
2.47.1
- [RFC PATCH 0/9] rust: (mostly) type safe VMState, Paolo Bonzini, 2024/12/30
- [RFC PATCH 4/9] rust: vmstate: implement Zeroable for VMStateField,
Paolo Bonzini <=
- [RFC PATCH 2/9] rust: vmstate: implement VMState for non-leaf types, Paolo Bonzini, 2024/12/30
- [RFC PATCH 1/9] rust: vmstate: add new type safe implementation, Paolo Bonzini, 2024/12/30
- [RFC PATCH 5/9] rust: vmstate: implement VMState for scalar types, Paolo Bonzini, 2024/12/30
- [RFC PATCH 6/9] rust: vmstate: add public utility macros to implement VMState, Paolo Bonzini, 2024/12/30
- [RFC PATCH 3/9] rust: vmstate: add varray support to vmstate_of!, Paolo Bonzini, 2024/12/30
- [RFC PATCH 8/9] rust: pl011: switch vmstate to new-style macros, Paolo Bonzini, 2024/12/30
- [RFC PATCH 9/9] rust: vmstate: remove translation of C vmstate macros, Paolo Bonzini, 2024/12/30
- [RFC PATCH 7/9] rust: qemu_api: add vmstate_struct and vmstate_cell, Paolo Bonzini, 2024/12/30