[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/18] Revert "util/timer: avoid deadlock when shutting down"
From: |
Peter Maydell |
Subject: |
Re: [PATCH 07/18] Revert "util/timer: avoid deadlock when shutting down" |
Date: |
Thu, 6 Feb 2025 15:53:05 +0000 |
On Mon, 3 Feb 2025 at 14:40, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> This reverts commit bc02be4508d8753d1f6071b77d10f4661587df6f.
>
> Now we catch attempts to clock_step to the next timer when none are
> enabled we can revert the previous attempt to prevent deadlock. As
> long as a new target time is given we will move time forward even if
> no timers will fire. This is desirable for tests which are checking
> that nothing changes when things are disabled.
>
> Previously most tests got away with it because --enable-slirp always
> has a timer running while the test is active.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH 00/18] maintainer updates for feb25 (qtest, gdbstub, plugins), Alex Bennée, 2025/02/03
- [PATCH 03/18] tests/qtest: don't step clock at start of npcm7xx periodic IRQ test, Alex Bennée, 2025/02/03
- [PATCH 01/18] tests/docker: replicate the check-rust-tools-nightly CI job, Alex Bennée, 2025/02/03
- [PATCH 02/18] tests/qtest: don't attempt to clock_step while waiting for virtio ISR, Alex Bennée, 2025/02/03
- [PATCH 05/18] tests/qtest: rename qtest_send_prefix and roll-up into qtest_send, Alex Bennée, 2025/02/03
- [PATCH 04/18] tests/qtest: simplify qtest_process_inbuf, Alex Bennée, 2025/02/03
- [PATCH 10/18] gdbstub: Allow the %d placeholder in the socket path, Alex Bennée, 2025/02/03
- [PATCH 07/18] Revert "util/timer: avoid deadlock when shutting down", Alex Bennée, 2025/02/03
- Re: [PATCH 07/18] Revert "util/timer: avoid deadlock when shutting down",
Peter Maydell <=
- [PATCH 14/18] osdep: Introduce qemu_kill_thread(), Alex Bennée, 2025/02/03
- [PATCH 06/18] tests/qtest: tighten up the checks on clock_step, Alex Bennée, 2025/02/03
- [PATCH 12/18] user: Introduce user/signal.h, Alex Bennée, 2025/02/03
- [PATCH 08/18] tests/qtest/migration: Add --full option, Alex Bennée, 2025/02/03
- [PATCH 13/18] user: Introduce host_interrupt_signal, Alex Bennée, 2025/02/03
- [PATCH 15/18] gdbstub: Allow late attachment, Alex Bennée, 2025/02/03
- [PATCH 11/18] gdbstub: Try unlinking the unix socket before binding, Alex Bennée, 2025/02/03
- [PATCH 09/18] tests/qtest/migration: Pick smoke tests, Alex Bennée, 2025/02/03
- [PATCH 16/18] docs/user: Document the %d placeholder and suspend=n QEMU_GDB features, Alex Bennée, 2025/02/03