[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices |
Date: |
Fri, 29 May 2020 15:45:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> writes:
> David Hildenbrand <david@redhat.com> writes:
>
>>>> +static void realize_event_facility(DeviceState *dev, Error **errp)
>>>> +{
>>>> + SCLPEventFacility *event_facility = EVENT_FACILITY(dev);
>>>> + Error *local_err = NULL;
>>>> +
>>>> + qdev_realize(DEVICE(&event_facility->quiesce),
>>>> + BUS(&event_facility->sbus), &local_err);
>>>> + if (local_err) {
>>>> + error_propagate(errp, local_err);
>>>> + return;
>>>> + }
>>>> + qdev_realize(DEVICE(&event_facility->cpu_hotplug),
>>>> + BUS(&event_facility->sbus), errp);
>>>
>>> Just wondering, do we have to care about un-realizing quiesce in case
>>> this fails?
>>
>> Just remembered that we fail creating the machine and therefore abort. So
>> not necessary :)
>
> True.
I chose to clean up on error anyway in v2. Thanks!
- [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices, Markus Armbruster, 2020/05/19
- Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices, David Hildenbrand, 2020/05/20
- Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices, David Hildenbrand, 2020/05/21
- Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices, Markus Armbruster, 2020/05/25
- Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices, Paolo Bonzini, 2020/05/25
- Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices, Markus Armbruster, 2020/05/26
- Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices, Paolo Bonzini, 2020/05/26
- Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices, Markus Armbruster, 2020/05/26
- Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices,
Markus Armbruster <=
Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices, Cornelia Huck, 2020/05/26
Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices, David Hildenbrand, 2020/05/26