Re: [PATCH v3] tests/acceptance: test hot(un)plug of ccw devices

[Wainer dos Santos Moschetta]

Hi,

On 12/8/20 9:28 AM, Cornelia Huck wrote:
> Hotplug a virtio-net-ccw device, and then hotunplug it again.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> v2->v3:
> - do the dmesg cleanout and waiting for messages properly [Thomas]
>
> Wainer: I dropped your r-b, as there had been too many changes for
>          me to be comfortable with retaining it
Ok.
> ---
>   tests/acceptance/machine_s390_ccw_virtio.py | 24 +++++++++++++++++++++
>   1 file changed, 24 insertions(+)

lgtm.

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

> diff --git a/tests/acceptance/machine_s390_ccw_virtio.py 
> b/tests/acceptance/machine_s390_ccw_virtio.py
> index 81d14088818c..864ef4ee6e9b 100644
> --- a/tests/acceptance/machine_s390_ccw_virtio.py
> +++ b/tests/acceptance/machine_s390_ccw_virtio.py
> @@ -99,3 +99,27 @@ class S390CCWVirtioMachine(Test):
>           exec_command_and_wait_for_pattern(self,
>                           'cat /sys/bus/pci/devices/000a\:00\:00.0/function_id',
>                           '0x0000000c')
> +        # add another device
> +        exec_command_and_wait_for_pattern(self,
> +                                    'dmesg -c > /dev/null; echo dm_clear\ 1',
> +                                    'dm_clear 1')
> +        self.vm.command('device_add', driver='virtio-net-ccw',
> +                        devno='fe.0.4711', id='net_4711')
> +        exec_command_and_wait_for_pattern(self,
> +                        'while ! (dmesg -c | grep CRW) ; do sleep 1 ; done',
> +                        'CRW reports')
> +        exec_command_and_wait_for_pattern(self, 'ls /sys/bus/ccw/devices/',
> +                                          '0.0.4711')
> +        # and detach it again
> +        exec_command_and_wait_for_pattern(self,
> +                                    'dmesg -c > /dev/null; echo dm_clear\ 2',
> +                                    'dm_clear 2')
> +        self.vm.command('device_del', id='net_4711')
> +        self.vm.event_wait(name='DEVICE_DELETED',
> +                           match={'data': {'device': 'net_4711'}})
> +        exec_command_and_wait_for_pattern(self,
> +                        'while ! (dmesg -c | grep CRW) ; do sleep 1 ; done',
> +                        'CRW reports')
> +        exec_command_and_wait_for_pattern(self,
> +                                          'ls /sys/bus/ccw/devices/0.0.4711',
> +                                          'No such file or directory')