|
From: | David Hildenbrand |
Subject: | Re: [PATCH v3 24/26] linux-user: elf: s390x: Prepare for Vector enhancements facility |
Date: | Mon, 7 Jun 2021 21:59:55 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 07.06.21 18:25, Richard Henderson wrote:
On 6/7/21 4:03 AM, David Hildenbrand wrote:+++ b/include/elf.h @@ -605,6 +605,7 @@ typedef struct { #define HWCAP_S390_HIGH_GPRS 512 #define HWCAP_S390_TE 1024 #define HWCAP_S390_VXRS 2048 +#define HWCAP_S390_VXRS_EXT 8192Probably best to fill in all of the values, even if we don't use them right now. Also, not the fault of this patch, but I don't think this belongs in include/elf.h. This is linux specific, not some part of the elf specification.
I can most certainly add all currently defined ones for s390x.We do have the same defines "misplaced" for other archs as well. I'd like to avoid cleaning that up as part of this series. Thanks!
-- Thanks, David / dhildenb
[Prev in Thread] | Current Thread | [Next in Thread] |