|
From: | Thomas Huth |
Subject: | Re: [RFC v6 08/13] target/s390x: split cpu-dump from helper.c |
Date: | Thu, 1 Jul 2021 14:35:20 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 29/06/2021 16.19, Cho, Yu-Chen wrote:
Splitting this functionality also allows us to make helper.c sysemu-only. Signed-off-by: Claudio Fontana <cfontana@suse.de> Signed-off-by: Cho, Yu-Chen <acho@suse.com> Acked-by: Cornelia Huck <cohuck@redhat.com> --- target/s390x/cpu-dump.c | 176 +++++++++++++++++++++++++++++++++++++++
Apart from the dump() function, the other functions here are are used in other contexts, too, so maybe the name is not very appropriate here... What about naming it "cpu-state.c" instead? Or include the functions in cpu.c directly?
Thomas
[Prev in Thread] | Current Thread | [Next in Thread] |