[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 10/22] qapi: introduce x-query-roms QMP command
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v4 10/22] qapi: introduce x-query-roms QMP command |
Date: |
Thu, 28 Oct 2021 18:55:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/28/21 17:54, Daniel P. Berrangé wrote:
> This is a counterpart to the HMP "info roms" command. It is being
> added with an "x-" prefix because this QMP command is intended as an
> adhoc debugging tool and will thus not be modelled in QAPI as fully
> structured data, nor will it have long term guaranteed stability.
> The existing HMP command is rewritten to call the QMP command.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> hmp-commands-info.hx | 2 +-
> hw/core/loader.c | 39 ++++++++++++++++++++++-----------------
> monitor/misc.c | 1 +
> qapi/machine.json | 12 ++++++++++++
> 4 files changed, 36 insertions(+), 18 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- Re: [PATCH v4 03/22] docs/devel: rename file for writing monitor commands, (continued)
- [PATCH v4 04/22] docs/devel: tweak headings in monitor command docs, Daniel P . Berrangé, 2021/10/28
- [PATCH v4 05/22] docs/devel: update error handling guidance for HMP commands, Daniel P . Berrangé, 2021/10/28
- [PATCH v4 06/22] monitor: introduce HumanReadableText and HMP support, Daniel P . Berrangé, 2021/10/28
- [PATCH v4 08/22] docs/devel: add example of command returning unstructured text, Daniel P . Berrangé, 2021/10/28
- [PATCH v4 09/22] docs/devel: document expectations for HMP commands in the future, Daniel P . Berrangé, 2021/10/28
- [PATCH v4 07/22] docs/devel: document expectations for QAPI data modelling for QMP, Daniel P . Berrangé, 2021/10/28
- [PATCH v4 10/22] qapi: introduce x-query-roms QMP command, Daniel P . Berrangé, 2021/10/28
- Re: [PATCH v4 10/22] qapi: introduce x-query-roms QMP command,
Philippe Mathieu-Daudé <=
- [PATCH v4 11/22] qapi: introduce x-query-profile QMP command, Daniel P . Berrangé, 2021/10/28
- [PATCH v4 12/22] qapi: introduce x-query-numa QMP command, Daniel P . Berrangé, 2021/10/28
- [PATCH v4 13/22] qapi: introduce x-query-usb QMP command, Daniel P . Berrangé, 2021/10/28
- [PATCH v4 14/22] qapi: introduce x-query-rdma QMP command, Daniel P . Berrangé, 2021/10/28
- [PATCH v4 15/22] qapi: introduce x-query-ramblock QMP command, Daniel P . Berrangé, 2021/10/28