[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system'
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system' |
Date: |
Wed, 4 Oct 2023 16:06:36 +0200 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 |
On 4/10/23 15:49, Paolo Bonzini wrote:
On Wed, Oct 4, 2023 at 3:41 PM Claudio Fontana <cfontana@suse.de> wrote:
On 10/4/23 14:37, Thomas Huth wrote:
On 04/10/2023 14.33, Daniel P. Berrangé wrote:
Am I mis-understanding what you mean by 'finishes' here, as
I see many references to softmmu remaining
In particular under configs/
I was also hoping it meant that we'd be changing configure
to allow
configure --target-list=x86_64-system
configure --target-list=x86_64-vm
for less typing
Maybe we should also bikeshed about the naming first... "system" is a quite
overloaded word in this context already, and "vm" sounds rather like
hardware-accelerated stuff ... what about using something like "sysemu"? Or
"fullsys" for "full system emulation" (in contrast to "user space"-only
emulation)?
I agree that changing other remnants should be done right
after this patch, for example $softmmu in configure. Changing
all targets is a very large and very user-visible change, it is
required but it should be planned very well.
As usual I should have been more verbose in my cover.
This series focus on the C code (and travis) to avoid misuse
of 'softmmu'.
Yes I agree it would be nice to also rename the binaries, but
this is a buildsys change (even if we use symlinks/aliases for
some deprecation period). This is not a tiny patch, and requires
thoughts.
On one hand I'd rather not rush renaming binaries -- annoying
users -- without a clear long term plan (which I'm not clear about).
On another hand I wouldn't delay Richard user-mode work.
Renaming binaries seems orthogonal to me, and could be done
later IMO.
As to the actual target names, I think system is the only
consistent choice since we have --enable/--disable-system
(as pointed out by Claudio) and qemu-system-*. sysemu
may make a little more sense in the codebase (we have
include/sysemu after all), but maybe that ship has sailed
since we have many occurrences of "system", for example
system_ss and other related sourcesets.
Paolo
- [PATCH 13/13] system: Rename softmmu/ directory as system/, (continued)
- [PATCH 13/13] system: Rename softmmu/ directory as system/, Philippe Mathieu-Daudé, 2023/10/04
- Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system', Daniel P . Berrangé, 2023/10/04
- Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system', Thomas Huth, 2023/10/04
- Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system', Daniel P . Berrangé, 2023/10/04
- Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system', Claudio Fontana, 2023/10/04
- Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system', Paolo Bonzini, 2023/10/04
- Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system', Daniel P . Berrangé, 2023/10/04
- Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system', Thomas Huth, 2023/10/06
- Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system',
Philippe Mathieu-Daudé <=
Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system', Paolo Bonzini, 2023/10/04