|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 00/12] hw: Strengthen SysBus & QBus API |
Date: | Wed, 18 Oct 2023 20:32:24 +0200 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 |
On 18/10/23 18:24, Thomas Huth wrote:
On 18/10/2023 16.11, Philippe Mathieu-Daudé wrote:Hi, This series ensure: - qbus_new() and sysbus_init_mmio() are called *before* a device is realized, - sysbus_mmio_map() is called *after* it is realized. First we fix some abuse, then we enforce in qdev/sysbus core code.I like the idea, and just had a try with "make check-qtest" with the patches here, but seems like there are more spots that need attention:
24/433 qemu:qtest+qtest-aarch64 / qtest-aarch64/qom-test ERROR 5.94s killed by signal 6 SIGABRT >>> QTEST_QEMU_BINARY=./qemu-system-aarch64 G_TEST_DBUS_DAEMON=/home/thuth/devel/qemu/tests/dbus-vmstate-daemon.sh QTEST_QEMU_IMG=./qemu-img PYTHON=/home/thuth/tmp/qemu-build/pyvenv/bin/python3 QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon MALLOC_PERTURB_=105 /home/thuth/tmp/qemu-build/tests/qtest/qom-test --tap -k ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――stderr:qemu-system-aarch64: sysbus_init_mmio(type:pxa2xx_pic) but object is realizedBroken pipe../../devel/qemu/tests/qtest/libqtest.c:203: kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped)
I neglected to mention that in the cover letter. This is mentioned here https://lore.kernel.org/qemu-devel/1b159c7a-f52c-3705-8757-c2b80a04965b@linaro.org/ I ping'd Peter on IRC because I'm not sure how to fix this PXA2xx code. Apparently it cames from commit 3f6c925f37 ("Use i2c_slave_init() to allocate the PXA (dummy) I2C slave"), which I presume was how to model slave<->master transactions *before* I2C bus modelling. Regards, Phil.
[Prev in Thread] | Current Thread | [Next in Thread] |