Re: [PATCH v2 0/3] hw/s390x: Don't call register_savevm_live() during instance_init()

[Juan Quintela]

Thomas Huth <thuth@redhat.com> wrote:
> We must not call register_savevm_live() during instance_init()
> since instances can be created at any time, e.g. during introspection
> of a device. We must register the savevm handler during realize()
> instead. Fix it now in the s390x devices.
>
> v2:
> - Fixed bug in the third patch ("sas" -> "dev")
> - Add an early return in case of error in the third patch
> - Added Acked-by/Reviewed by from David and Eric (thanks!)
>
> Thomas Huth (3):
>   hw/s390x/s390-skeys: Don't call register_savevm_live() during
>     instance_init()
>   hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled"
>     property
>   hw/s390x/s390-stattrib: Don't call register_savevm_live() during
>     instance_init()
>
>  hw/s390x/s390-skeys.c    | 35 ++++++-------------------
>  hw/s390x/s390-stattrib.c | 55 +++++++++++++++-------------------------
>  2 files changed, 29 insertions(+), 61 deletions(-)

Acked-by: Juan Quintela <quintela@redhat.com>

It makes things work for my test, Thanks.

Should I get those through the migration tree?

Later, Juan.