[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 38/45] hw/riscv: use qemu_configure_nic_device()
From: |
David Woodhouse |
Subject: |
Re: [PATCH 38/45] hw/riscv: use qemu_configure_nic_device() |
Date: |
Wed, 25 Oct 2023 16:51:53 +0100 |
User-agent: |
Evolution 3.44.4-0ubuntu2 |
On Wed, 2023-10-25 at 12:42 -0300, Daniel Henrique Barboza wrote:
>
> I believe you forgot to remove the 'nd' variable. Building with this patch
> (applying
> patches 1 to 4 first) fails with:
>
>
> ../hw/riscv/microchip_pfsoc.c: In function ‘microchip_pfsoc_soc_realize’:
> ../hw/riscv/microchip_pfsoc.c:205:14: error: unused variable ‘nd’
> [-Werror=unused-variable]
> 205 | NICInfo *nd;
> | ^~
> cc1: all warnings being treated as errors
>
>
> Patch looks good otherwise. Thanks,
>
> Daniel
Thanks.
Yes, I'd spotted that my build coverage was incomplete and fixed a few
of those. My tree at
https://git.infradead.org/users/dwmw2/qemu.git/shortlog/refs/heads/xenfv
does actually build now on all platforms, and the CI tests ran in
https://gitlab.com/dwmw2/qemu/-/pipelines/1049153457 with only a minor
whine from checkpatch about the imported Xen headers and some long
lines which were like that before I touched them.
I haven't yet re-spammed the list with the 40-odd patches touching all
the platforms though, as noted in
https://lore.kernel.org/qemu-devel/20231025145042.627381-1-dwmw2@infradead.org/T/
smime.p7s
Description: S/MIME cryptographic signature
- [PATCH 44/45] net: remove qemu_show_nic_models(), qemu_find_nic_model(), (continued)
- [PATCH 44/45] net: remove qemu_show_nic_models(), qemu_find_nic_model(), David Woodhouse, 2023/10/22
- [PATCH 29/45] hw/arm/stellaris: use qemu_find_nic_info(), David Woodhouse, 2023/10/22
- [PATCH 13/45] hw/mips/malta: use pci_init_nic_devices(), David Woodhouse, 2023/10/22
- [PATCH 26/45] hw/net/lan9118: use qemu_configure_nic_device(), David Woodhouse, 2023/10/22
- [PATCH 10/45] hw/hppa: use pci_init_nic_devices(), David Woodhouse, 2023/10/22
- [PATCH 15/45] hw/ppc/prep: use pci_init_nic_devices(), David Woodhouse, 2023/10/22
- [PATCH 02/45] net: report list of available models according to platform, David Woodhouse, 2023/10/22
- [PATCH 37/45] hw/openrisc/openrisc_sim: use qemu_create_nic_device(), David Woodhouse, 2023/10/22
- [PATCH 38/45] hw/riscv: use qemu_configure_nic_device(), David Woodhouse, 2023/10/22
- [PATCH 16/45] hw/ppc/spapr: use qemu_get_nic_info() and pci_init_nic_devices(), David Woodhouse, 2023/10/22
- [PATCH 34/45] hw/microblaze: use qemu_configure_nic_device(), David Woodhouse, 2023/10/22
- [PATCH 28/45] hw/arm/npcm7xx: use qemu_configure_nic_device, allow emc0/emc1 as aliases, David Woodhouse, 2023/10/22
- [PATCH 25/45] hw/net/smc91c111: use qemu_configure_nic_device(), David Woodhouse, 2023/10/22
- [PATCH 36/45] hw/net/lasi_i82596: use qemu_configure_nic_device(), David Woodhouse, 2023/10/22
- [PATCH 21/45] hw/arm/allwinner: use qemu_configure_nic_device(), David Woodhouse, 2023/10/22
- [PATCH 12/45] hw/mips/fuloong2e: use pci_init_nic_devices(), David Woodhouse, 2023/10/22
- [PATCH 42/45] net: remove qemu_check_nic_model(), David Woodhouse, 2023/10/22
- [PATCH 43/45] hw/pci: remove pci_nic_init_nofail(), David Woodhouse, 2023/10/22
- [PATCH 17/45] hw/ppc: use pci_init_nic_devices(), David Woodhouse, 2023/10/22