Re: [PATCH 0/4] target/s390x/cpu: Restrict CPUS390XState declaration to 'cpu.h'

[Thomas Huth]

On 06/11/2023 12.44, Philippe Mathieu-Daudé wrote:
> In order to restrict CPUS390XState declaration to "cpu.h" (both
> target-specific):
> - have the following prototypes take a S390CPU* instead:
>    . css_do_sic()
>    . sclp_service_call()
>    . sclp_service_call_protected()
> - restrict cpu_get_tb_cpu_state() definition to TCG
>
> Philippe Mathieu-Daudé (4):
>    hw/s390x/css: Have css_do_sic() take S390CPU instead of CPUS390XState
>    hw/s390x/sclp: Have sclp_service_call[_protected]() take S390CPU*
>    target/s390x/cpu: Restrict cpu_get_tb_cpu_state() definition to TCG
>    target/s390x/cpu: Restrict CPUS390XState declaration to 'cpu.h'
>
>   include/hw/s390x/css.h         |  2 +-
>   include/hw/s390x/sclp.h        |  5 ++---
>   target/s390x/cpu-qom.h         |  2 --
>   target/s390x/cpu.h             | 11 ++++++++---
>   hw/s390x/css.c                 |  3 ++-
>   hw/s390x/sclp.c                |  7 ++++---
>   target/s390x/kvm/kvm.c         |  4 ++--
>   target/s390x/tcg/misc_helper.c |  5 +++--
>   8 files changed, 22 insertions(+), 17 deletions(-)

FWIW:

Series:
Reviewed-by: Thomas Huth <thuth@redhat.com>