Re: [PATCH 1/2] target/s390x: Emulate CVDG

[Thomas Huth]

On 15/01/2024 21.21, Ilya Leoshkevich wrote:
> CVDG is the same as CVD, except that it converts 64 bits into 128,
> rather than 32 into 64. Use larger data types in the CVD helper and
> reuse it.
>
> Reported-by: Ido Plat <Ido.Plat@ibm.com>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>   target/s390x/helper.h            |  1 +
>   target/s390x/tcg/insn-data.h.inc |  1 +
>   target/s390x/tcg/int_helper.c    | 11 ++++++++---
>   target/s390x/tcg/translate.c     |  8 ++++++++
>   4 files changed, 18 insertions(+), 3 deletions(-)

Looks sane to me!

Reviewed-by: Thomas Huth <thuth@redhat.com>