[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/7] target/s390x/cpu_model: Drop local @err in s390_realize_c
From: |
Zhao Liu |
Subject: |
[PATCH v2 2/7] target/s390x/cpu_model: Drop local @err in s390_realize_cpu_model() |
Date: |
Thu, 25 Apr 2024 11:12:27 +0800 |
Use @errp to fetch error information directly and drop the local
variable @err.
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
target/s390x/cpu_models.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 8cb47d905fb4..052540a866ac 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -577,7 +577,6 @@ S390CPUModel *get_max_cpu_model(Error **errp)
void s390_realize_cpu_model(CPUState *cs, Error **errp)
{
ERRP_GUARD();
- Error *err = NULL;
S390CPUClass *xcc = S390_CPU_GET_CLASS(cs);
S390CPU *cpu = S390_CPU(cs);
const S390CPUModel *max_model;
@@ -606,8 +605,7 @@ void s390_realize_cpu_model(CPUState *cs, Error **errp)
cpu->model->cpu_ver = max_model->cpu_ver;
check_consistency(cpu->model);
- if (!check_compatibility(max_model, cpu->model, &err)) {
- error_propagate(errp, err);
+ if (!check_compatibility(max_model, cpu->model, errp)) {
return;
}
--
2.34.1
- [PATCH v2 0/7] s390x/cpu_models: Misc cleanup on returned error code and local @err variables, Zhao Liu, 2024/04/24
- [PATCH v2 1/7] target/s390x/cpu_model: Make check_compatibility() return boolean, Zhao Liu, 2024/04/24
- [PATCH v2 2/7] target/s390x/cpu_model: Drop local @err in s390_realize_cpu_model(),
Zhao Liu <=
- [PATCH v2 3/7] target/s390x: Remove KVM stubs in cpu_models.h, Zhao Liu, 2024/04/24
- [PATCH v2 4/7] target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return boolean, Zhao Liu, 2024/04/24
- [PATCH v2 5/7] target/s390x/cpu_models: Drop local @err in get_max_cpu_model(), Zhao Liu, 2024/04/24
- [PATCH v2 6/7] target/s390x/cpu_models: Make kvm_s390_apply_cpu_model() return boolean, Zhao Liu, 2024/04/24
- [PATCH v2 7/7] target/s390x/cpu_models_sysemu: Drop local @err in apply_cpu_model(), Zhao Liu, 2024/04/24