[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/2] target/s390x: report deprecated-props in cpu-model-ex
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 1/2] target/s390x: report deprecated-props in cpu-model-expansion reply |
Date: |
Fri, 26 Apr 2024 10:42:04 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Collin Walling <walling@linux.ibm.com> writes:
> Retain a list of deprecated features disjoint from any particular
> CPU model. A query-cpu-model-expansion reply will now provide a list of
> properties (i.e. features) that are flagged as deprecated. Example:
>
> {
> "return": {
> "model": {
> "name": "z14.2-base",
> "deprecated-props": [
> "bpb",
> "csske"
> ],
> "props": {
> "pfmfi": false,
> "exrl": true,
> ...a lot more props...
> "skey": false,
> "vxpdeh2": false
> }
> }
> }
> }
>
> It is recommended that s390 guests operate with these features
> explicitly disabled to ensure compatability with future hardware.
>
> Signed-off-by: Collin Walling <walling@linux.ibm.com>
> ---
> qapi/machine-target.json | 5 ++++-
> target/s390x/cpu_features.c | 14 ++++++++++++++
> target/s390x/cpu_features.h | 1 +
> target/s390x/cpu_models_sysemu.c | 6 ++++++
> 4 files changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/machine-target.json b/qapi/machine-target.json
> index 29e695aa06..3799a60e3d 100644
> --- a/qapi/machine-target.json
> +++ b/qapi/machine-target.json
> @@ -20,11 +20,14 @@
> #
> # @props: a dictionary of QOM properties to be applied
> #
> +# @deprecated-props: a list of QOM properties that are flagged as deprecated
Deprecated by whom? QEMU? The CPU vendor?
docs/devel/qapi-code-gen.rst:
For legibility, wrap text paragraphs so every line is at most 70
characters long.
> +#
> # Since: 2.8
> ##
> { 'struct': 'CpuModelInfo',
> 'data': { 'name': 'str',
> - '*props': 'any' } }
> + '*props': 'any',
> + '*deprecated-props': ['str'] } }
>
> ##
> # @CpuModelExpansionType:
[...]