Re: [PATCH 0/3] testing/next: s390x gitlab updates

[Richard Henderson]

On 4/26/24 08:39, Alex Bennée wrote:
> I was asked to update the custom gitlab runner from the aging 20.04 to
> 22.04 which has been done. However I needed to update the provisioning
> scripts and clean-up some of the cruft. Sadly this doesn't seem to be
> passing cleanly as we have:
>
>    - qtest-s390x/migration-test ERROR           98.94s   killed by signal 6 
> SIGABRT
>    - failing TCG tests (on s390x HW)
>       - float_convd fails against a generated reference
>       - clc returns 1

I've had a look at the clc failure.

It fails because of bad address space layout, where the NULL page isn't unmapped, so the 
expected SIGSEGV does *not* happen.

This is unfortunate and we could do better.

However, with the upgrade, --static --enable-pie no longer works.
From config.log,

cc -m64 -Werror -fPIE -DPIE -o config-temp/qemu-conf.exe 
config-temp/qemu-conf.c -static-pie
/usr/bin/ld: cannot find rcrt1.o: No such file or directory

which suggests a missing package.

Alternately, we could drop --static, as it's not really relevant to this testing.  With 
that, we get PIE dynamically linked executables, which do not trigger the bad layout.

But at some point we should make sure that the NULL page(s) are reserved PROT_NONE for the 
guest, which ensure this stays fixed.


r~