[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 7/7] vfio/{ap, ccw}: Use warn_report_err() for IRQ notifier r
From: |
Duan, Zhenzhong |
Subject: |
RE: [PATCH 7/7] vfio/{ap, ccw}: Use warn_report_err() for IRQ notifier registration errors |
Date: |
Thu, 23 May 2024 08:45:53 +0000 |
>-----Original Message-----
>From: Cédric Le Goater <clg@redhat.com>
>Subject: [PATCH 7/7] vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier
>registration errors
>
>vfio_ccw_register_irq_notifier() and vfio_ap_register_irq_notifier()
>errors are currently reported using error_report_err(). Since they are
>not considered as failing conditions, using warn_report_err() is more
>appropriate.
>
>Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Thanks
Zhenzhong
>---
> hw/vfio/ap.c | 2 +-
> hw/vfio/ccw.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
>index
>c12531a7886a2fe87598be0861fba5923bd2c206..0c4354e3e70169ec072e1
>6da0919936647d1d351 100644
>--- a/hw/vfio/ap.c
>+++ b/hw/vfio/ap.c
>@@ -172,7 +172,7 @@ static void vfio_ap_realize(DeviceState *dev, Error
>**errp)
> * Report this error, but do not make it a failing condition.
> * Lack of this IRQ in the host does not prevent normal operation.
> */
>- error_report_err(err);
>+ warn_report_err(err);
> }
>
> return;
>diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
>index
>36f2677a448c5e31523dcc3de7d973ec70e4a13c..1f8e1272c7555cd0a77048
>1d1ae92988f6e2e62e 100644
>--- a/hw/vfio/ccw.c
>+++ b/hw/vfio/ccw.c
>@@ -616,7 +616,7 @@ static void vfio_ccw_realize(DeviceState *dev, Error
>**errp)
> * Report this error, but do not make it a failing condition.
> * Lack of this IRQ in the host does not prevent normal operation.
> */
>- error_report_err(err);
>+ warn_report_err(err);
> }
>
> return;
>--
>2.45.1
- Re: [PATCH 4/7] s390x/css: Make S390CCWDeviceClass::realize return bool, (continued)
- [PATCH 3/7] hw/s390x/ccw: Remove local Error variable from s390_ccw_realize(), Cédric Le Goater, 2024/05/22
- [PATCH 5/7] vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize(), Cédric Le Goater, 2024/05/22
- [PATCH 6/7] vfio/ccw: Fix the missed unrealize() call in error path, Cédric Le Goater, 2024/05/22
- [PATCH 7/7] vfio/{ap, ccw}: Use warn_report_err() for IRQ notifier registration errors, Cédric Le Goater, 2024/05/22
- Re: [PATCH 0/7] s390x/ccw: Error reporting cleanups, Eric Farman, 2024/05/23
- Re: [PATCH 0/7] s390x/ccw: Error reporting cleanups, Thomas Huth, 2024/05/27