[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 3/3] tests/qtest/migration-test: Enable test_ignore_share
From: |
Fabiano Rosas |
Subject: |
Re: [RFC PATCH 3/3] tests/qtest/migration-test: Enable test_ignore_shared |
Date: |
Mon, 27 May 2024 12:11:45 -0300 |
Peter Xu <peterx@redhat.com> writes:
> On Mon, May 27, 2024 at 09:42:28AM -0300, Fabiano Rosas wrote:
>> However, there is an issue here still on all archs - which might very
>> well have been the original issue - which is the fact that the
>> containers on the Gitlab CI have limits on shared memory usage.
>> Unfortunately we cannot enable this test for the CI, so it needs a check
>> on the GITLAB_CI environment variable.
>
> Another option is we teach migration-test to detect whether memory_size of
> shmem is available, skip if not. It can be a sequence of:
>
> memfd_create()
> fallocate()
> ret = madvise(MADV_POPULATE_WRITE)
>
> To be run at the entry of migration-test, and skip all use_shmem=true tests
> if ret != 0, or any step failed above.
There are actually two issues:
1) Trying to run a test that needs more shmem than available in the
container. This is covered well by your suggestion.
2) Trying to use some shmem while another test has already consumed all
shmem. I'm not sure if this can be done reliably as the tests run in
parallel.
- Re: [RFC PATCH 1/3] hw/intc/s390_flic: Migrate pending state, (continued)
[RFC PATCH 2/3] tests/qtest/migration-test: enable on s390x, Nicholas Piggin, 2024/05/25
[RFC PATCH 3/3] tests/qtest/migration-test: Enable test_ignore_shared, Nicholas Piggin, 2024/05/25
Re: [RFC PATCH 0/3] Fix s390x flic migration and add some more qtests, Thomas Huth, 2024/05/27