Re: [PATCH 4/4] hw/s390x: Deprecate the QMP @dump-skeys command

[Thomas Huth]

On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote:
> Prefer @dump-s390-skeys which is target agnostic.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   docs/about/deprecated.rst | 5 +++++
>   qapi/misc-target.json     | 5 +++++
>   2 files changed, 10 insertions(+)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 40585ca7d5..3cb43085ba 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -148,6 +148,11 @@ accepted incorrect commands will return an error. Users 
> should make sure that
>   all arguments passed to ``device_add`` are consistent with the documented
>   property types.
>   
> +``dump-skeys`` (since 9.1)
> +''''''''''''''''''''''''''
> +
> +Use the more generic ``dump-s390-skeys`` command.

FWIW, that's "more specific", not "more generic".

But as I said in my reply to the cover letter, we should maybe consider a 
more generic command instead, indeed.

 Thomas