qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/s390x: Fix tracing header path in TCG mem_helper.c


From: Peter Maydell
Subject: Re: [PATCH] target/s390x: Fix tracing header path in TCG mem_helper.c
Date: Thu, 6 Jun 2024 13:09:07 +0100

On Thu, 6 Jun 2024 at 11:30, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Commit c9274b6bf0 ("target/s390x: start moving TCG-only code
> to tcg/") moved mem_helper.c, but the trace-events file is
> still in the parent directory, so is the generated trace.h.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Ideally we should only use trace events from current directory.

Mmm, I was wondering if maybe that would be the better approach.

A quick grep suggests the only other place doing a "../trace.h"
include is in include/hw/xen/interface/hvm/hvm_op.h, which is
unrelated, because it's pulling in the non-autogenerated
include/hw/xen/interface/trace.h.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]