qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 21/22] qapi: Inline and remove QERR_UNSUPPORTED defini


From: Konstantin Kostiuk
Subject: Re: [RFC PATCH v2 21/22] qapi: Inline and remove QERR_UNSUPPORTED definition
Date: Wed, 12 Jun 2024 16:27:49 +0300

Hi Markus and Philippe,

I agree to remove QERR_UNSUPPORTED and have more specific errors
or even remove the functions from the schema in some cases instead of
copy-paste QERR_UNSUPPORTED from platform to platform.

Best Regards,
Konstantin Kostiuk.


On Wed, Jun 12, 2024 at 4:07 PM Markus Armbruster <armbru@redhat.com> wrote:
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Michael, Konstantin, QERR_UNSUPPORTED is only used by QGA.
>
> Do you mind giving our maintainer's position on Markus
> analysis so we can know how to proceed with this definition?

Daniel Berrangé recently posted patches that get rid of most instances
of QERR_UNSUPPORTED:

    [PATCH 00/20] qga: clean up command source locations and conditionals
    https://lore.kernel.org/qemu-devel/20240604134933.220112-1-berrange@redhat.com/

I pointed out a possible opportunity to remove even more.

I think we should let the dust settle there, then figure out how to
eliminate remaining QERR_UNSUPPORTED, if any.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]