[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/11] s390: Convert virtio-ccw, cpu to three-phase reset,
From: |
Nina Schoetterl-Glausch |
Subject: |
Re: [PATCH v2 00/11] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup |
Date: |
Mon, 09 Sep 2024 15:47:01 +0200 |
User-agent: |
Evolution 3.52.3 (3.52.3-1.fc40) |
On Fri, 2024-09-06 at 15:38 +0100, Peter Maydell wrote:
> On Fri, 30 Aug 2024 at 15:58, Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > The main aim of this patchseries is to remove the two remaining uses
> > of device_class_set_parent_reset() in the tree, which are virtio-ccw
> > and the s390 CPU class. Doing that lets us do some followup cleanup.
> > (The diffstat looks alarming but is almost all coccinelle automated
> > changes.)
> >
> > Changes v1->v2:
> > * new patch 1 to convert hw/s390/ccw-device
> > (fixes bug discovered via s390 CI testing in v1)
> > * a couple of patches are already upstream
> > * in the target/s390 cpu patch, fix sigp_cpu_reset() to use
> > RESET_TYPE_S390_CPU_NORMAL
> > * new patches 10, 11 which take advantage of the new function
> > device_class_set_legacy_reset() to allow us to replace the
> > generic Resettable transitional_function machinery with a
> > simple wrapper that adapts from the API of the hold method
> > to the one used by the legacy reset method
> >
> > Patches 1, 10, 11 need review. I believe that patch 1 should have
> > fixed the intermittent s390 issue we found with v1 of the patchset,
> > but if you could run these through the s390 CI again I'd
> > appreciate it.
>
> I'm going to apply this series to my target-arm.next queue.
>
> Let me know if you need more time to CI/test/whatever it on
> the s390 side before it goes upstream.
CI looks good.
>
> thanks
> -- PMM