[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached() |
|
Date: |
Wed, 11 Sep 2024 07:33:36 -0500 |
|
User-agent: |
NeoMutt/20240425 |
On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
A general suggestion for the entire series: please use a commit
message that explains why this is a good idea. Even something as
boiler-plate as "refer to commit XXX for rationale" that can be
copy-pasted into all the other commits is better than nothing,
although a self-contained message is best. Maybe:
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- [PATCH 00/39] Use g_assert_not_reached instead of (g_)assert(0, false), Pierrick Bouvier, 2024/09/10
- [PATCH 02/39] hw/acpi: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/10
- [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/10
- Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached(),
Eric Blake <=
- Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached(), Eric Blake, 2024/09/11
- Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached(), Maciej S. Szmigiero, 2024/09/11
- Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached(), Richard W.M. Jones, 2024/09/11
- Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/11
- Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached(), Richard Henderson, 2024/09/11
- Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached(), Thomas Huth, 2024/09/11
- Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/11
- Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/11
[PATCH 03/39] hw/arm: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/10
[PATCH 05/39] hw/core: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/10